Page MenuHomePhabricator
Differential D10584

Partially modernize Doorkeeper/Asana bridge
ClosedPublic
Actions

Authored by epriestley on Sep 27 2014, 12:45 AM.
Tags
None
Referenced Files
F18845958: D10584.diff
Wed, Oct 29, 3:31 PM
F18830661: D10584.diff
Sat, Oct 25, 7:54 AM
F18812570: D10584.id25417.diff
Mon, Oct 20, 10:28 AM
F18777347: D10584.id25456.diff
Sat, Oct 11, 2:23 AM
F18774210: D10584.id.diff
Thu, Oct 9, 3:55 PM
F18761755: D10584.id.diff
Mon, Oct 6, 4:08 PM
F18759133: D10584.diff
Mon, Oct 6, 2:01 AM
F18740501: D10584.id.diff
Thu, Oct 2, 3:51 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6201: Inline comment text not publishing into Asana
Commits
Restricted Diffusion Commit
rP3fe226f9f037: Partially modernize Doorkeeper/Asana bridge
Summary

Fixes T6201. This stuff didn't fully get updated for ApplicationTransactions. Get it working again (notably, make inline comment text publish) and clean it up a little bit.

Test Plan
  • Published a Differential feed story into Asana with comment text.
  • Pulbished a Diffusion feed story into Asana with comment text.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25417.Sep 27 2014, 12:45 AM
epriestley retitled this revision from to Partially modernize Doorkeeper/Asana bridge.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6201: Inline comment text not publishing into Asana.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 27 2014, 12:45 AM
Harbormaster completed remote builds in B2671: Diff 25417.Sep 27 2014, 12:45 AM
btrahan accepted this revision.Sep 30 2014, 4:45 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 4:45 PM
Closed by commit rP3fe226f9f037: Partially modernize Doorkeeper/Asana bridge (authored by epriestley, committed by epriestley).Oct 1 2014, 2:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25456

View Options

src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php

Loading...
View Options

src/applications/doorkeeper/engine/DoorkeeperFeedStoryPublisher.php

Loading...
View Options

src/applications/feed/constants/PhabricatorFeedStoryTypeConstants.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStory.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryAudit.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryDifferential.php

Loading...
View Options

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility