Page MenuHomePhabricator

Generate expected schemata for User/People tables
ClosedPublic

Authored by epriestley on Sep 26 2014, 9:26 PM.
Tags
None
Referenced Files
F19907254: D10580.id.diff
Wed, Apr 1, 9:08 AM
F19811086: D10580.diff
Mar 3 2026, 10:32 PM
F19786604: D10580.id25407.diff
Feb 25 2026, 10:42 AM
F19786603: D10580.id25409.diff
Feb 25 2026, 10:41 AM
F19600395: D10580.diff
Feb 3 2026, 3:25 AM
F18850180: D10580.id25407.diff
Oct 30 2025, 2:59 PM
F18841135: D10580.diff
Oct 28 2025, 7:14 AM
F18804342: D10580.id25407.diff
Oct 18 2025, 7:28 AM
Subscribers

Details

Summary

Ref T1191. Some notes here:

  • Drops the old LDAP and OAuth info tables. These were migrated to the ExternalAccount table a very long time ago.
  • Separates surplus/missing keys from other types of surplus/missing things. In the long run, my plan is to have only two notice levels:
    • Error: something we can't fix (missing database, table, or column; overlong key).
    • Warning: something we can fix (surplus anything, missing key, bad column type, bad key columns, bad uniqueness, bad collation or charset).
    • For now, retaining three levels is helpful in generating all the expected scheamta.
Test Plan
  • Saw ~200 issues resolve, leaving ~1,300.
  • Grepped for removed tables.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Generate expected schemata for User/People tables.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Give patches an umambiguous apply order.
This revision is now accepted and ready to land.Sep 30 2014, 4:44 PM
This revision was automatically updated to reflect the committed changes.