Page MenuHomePhabricator

Generate expected schemata for User/People tables
ClosedPublic

Authored by epriestley on Sep 26 2014, 9:26 PM.
Tags
None
Referenced Files
F18103098: D10580.id25407.diff
Sun, Aug 10, 1:42 AM
F18093034: D10580.id25407.diff
Thu, Aug 7, 2:53 PM
F18090238: D10580.diff
Wed, Aug 6, 2:56 PM
F18084003: D10580.id25409.diff
Tue, Aug 5, 1:03 PM
F18048073: D10580.id.diff
Sun, Aug 3, 1:20 PM
F18042852: D10580.id25457.diff
Sun, Aug 3, 5:17 AM
F17941085: D10580.id25407.diff
Thu, Jul 31, 5:02 AM
F17932128: D10580.id.diff
Wed, Jul 30, 7:46 PM
Subscribers

Details

Summary

Ref T1191. Some notes here:

  • Drops the old LDAP and OAuth info tables. These were migrated to the ExternalAccount table a very long time ago.
  • Separates surplus/missing keys from other types of surplus/missing things. In the long run, my plan is to have only two notice levels:
    • Error: something we can't fix (missing database, table, or column; overlong key).
    • Warning: something we can fix (surplus anything, missing key, bad column type, bad key columns, bad uniqueness, bad collation or charset).
    • For now, retaining three levels is helpful in generating all the expected scheamta.
Test Plan
  • Saw ~200 issues resolve, leaving ~1,300.
  • Grepped for removed tables.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Generate expected schemata for User/People tables.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Give patches an umambiguous apply order.
This revision is now accepted and ready to land.Sep 30 2014, 4:44 PM
This revision was automatically updated to reflect the committed changes.