Page MenuHomePhabricator

Generate expected schemata for User/People tables
ClosedPublic

Authored by epriestley on Sep 26 2014, 9:26 PM.
Tags
None
Referenced Files
F18804342: D10580.id25407.diff
Sat, Oct 18, 7:28 AM
F18753401: D10580.diff
Sat, Oct 4, 6:37 PM
F18744122: D10580.id25407.diff
Fri, Oct 3, 1:57 AM
F18673936: D10580.id25457.diff
Sep 25 2025, 12:36 PM
F18672484: D10580.id25457.diff
Sep 25 2025, 7:36 AM
F18654466: D10580.diff
Sep 22 2025, 10:19 AM
F18653301: D10580.diff
Sep 21 2025, 12:09 PM
F18647930: D10580.diff
Sep 19 2025, 3:13 PM
Subscribers

Details

Summary

Ref T1191. Some notes here:

  • Drops the old LDAP and OAuth info tables. These were migrated to the ExternalAccount table a very long time ago.
  • Separates surplus/missing keys from other types of surplus/missing things. In the long run, my plan is to have only two notice levels:
    • Error: something we can't fix (missing database, table, or column; overlong key).
    • Warning: something we can fix (surplus anything, missing key, bad column type, bad key columns, bad uniqueness, bad collation or charset).
    • For now, retaining three levels is helpful in generating all the expected scheamta.
Test Plan
  • Saw ~200 issues resolve, leaving ~1,300.
  • Grepped for removed tables.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Generate expected schemata for User/People tables.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Give patches an umambiguous apply order.
This revision is now accepted and ready to land.Sep 30 2014, 4:44 PM
This revision was automatically updated to reflect the committed changes.