Paths

Table of Contentst

Differential D10567

Add a linter rule to detect variable arguments for `break` and `continue`
ClosedPublic
Actions

Authored by joshuaspence on Sep 25 2014, 9:47 PM.

Tags

None

Referenced Files

	F13177760: D10567.diff
	Wed, May 8, 7:56 PM

	Unknown Object (File)
	Thu, Apr 25, 12:38 AM

	Unknown Object (File)
	Apr 7 2024, 10:44 AM

	Unknown Object (File)
	Mar 28 2024, 6:21 PM

	Unknown Object (File)
	Mar 21 2024, 1:08 AM

	Unknown Object (File)
	Feb 16 2024, 11:22 AM

	Unknown Object (File)
	Feb 4 2024, 4:16 PM

	Unknown Object (File)
	Dec 25 2023, 9:57 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC8ed1459ecdba: Add a linter rule to detect variable arguments for `break` and `continue`

Summary

In PHP 5.4, the break and continue statements no longer accept variable arguments (e.g., break 1 + foo() * $bar;). Static arguments still work, such as break 2;. As a side effect of this change break 0; and continue 0; are no longer allowed.

Test Plan

Added some test cases.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 25385.Sep 25 2014, 9:47 PM

joshuaspence retitled this revision from to Add a linter rule to detect variable arguments for `break` and `continue`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 25 2014, 9:47 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2650: Diff 25385.Sep 25 2014, 9:48 PM

epriestley accepted this revision.Sep 25 2014, 9:50 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 25 2014, 9:50 PM

Add test cases for continue

Harbormaster completed remote builds in B2653: Diff 25390.Sep 25 2014, 10:42 PM

Closed by commit rARC8ed1459ecdba: Add a linter rule to detect variable arguments for `break` and `continue` (authored by joshuaspence, committed by joshuaspence).Sep 25 2014, 10:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

46 lines

__tests__/

xhpast/

	php53-features.lint-test
	php53.lint-test

php53.lint-test

	php54-features.lint-test
	php54.lint-test

php54-incompat.lint-test

17 lines

php54.lint-test

Diff 25392

src/lint/linter/ArcanistXHPASTLinter.php

Loading...

src/lint/linter/tests/xhpast/php53-features.lint-test

Loading...

src/lint/linter/tests/xhpast/php53.lint-test

Loading...

src/lint/linter/tests/xhpast/php54-features.lint-test

Loading...

src/lint/linter/tests/xhpast/php54-incompat.lint-test

Loading...

src/lint/linter/tests/xhpast/php54.lint-test

Loading...