Page MenuHomePhabricator
Differential D10567

Add a linter rule to detect variable arguments for `break` and `continue`
ClosedPublic
Actions

Authored by joshuaspence on Sep 25 2014, 9:47 PM.
Tags
None
Referenced Files
F15434430: D10567.id25392.diff
Tue, Mar 25, 3:38 AM
F15428766: D10567.id25390.diff
Sun, Mar 23, 10:13 PM
F15428727: D10567.id25385.diff
Sun, Mar 23, 9:56 PM
F15422354: D10567.diff
Sat, Mar 22, 7:35 AM
F15413661: D10567.diff
Wed, Mar 19, 8:23 PM
F15403617: D10567.diff
Tue, Mar 18, 4:08 AM
F15393072: D10567.id25390.diff
Sat, Mar 15, 7:25 PM
F15389451: D10567.diff
Sat, Mar 15, 5:15 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC8ed1459ecdba: Add a linter rule to detect variable arguments for `break` and `continue`
Summary

In PHP 5.4, the break and continue statements no longer accept variable arguments (e.g., break 1 + foo() * $bar;). Static arguments still work, such as break 2;. As a side effect of this change break 0; and continue 0; are no longer allowed.

Test Plan

Added some test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 25385.Sep 25 2014, 9:47 PM
joshuaspence retitled this revision from to Add a linter rule to detect variable arguments for `break` and `continue`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 25 2014, 9:47 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2650: Diff 25385.Sep 25 2014, 9:48 PM
epriestley accepted this revision.Sep 25 2014, 9:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2014, 9:50 PM
joshuaspence updated this revision to Diff 25390.Sep 25 2014, 10:42 PM
joshuaspence edited edge metadata.

Add test cases for continue

Harbormaster completed remote builds in B2653: Diff 25390.Sep 25 2014, 10:42 PM
Closed by commit rARC8ed1459ecdba: Add a linter rule to detect variable arguments for `break` and `continue` (authored by joshuaspence, committed by joshuaspence).Sep 25 2014, 10:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
46 lines
__tests__/
xhpast/
17 lines

Diff 25392

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/php53-features.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/php53.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/php54-features.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/php54-incompat.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/php54.lint-test

Loading...
Phabricator · Built by Phacility