Differential D10557

Fix custom blueprint attributes to work when no attributes are specified
AbandonedPublic
Actions

Authored by hach-que on Sep 25 2014, 2:34 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T2015: Implement Drydock

Summary

Ref T2015. This fixes custom attribute parsing so that it works when the attribute text is empty (previously it would never match if there was empty text for the requirements and provided attributes).

Test Plan

Tested allocation of a resource when the blueprint attributes and lease host requirements set to empty text.

Diff Detail

Repository

rP Phabricator

Branch

attribute-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2635
Build 2639: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 25363.Sep 25 2014, 2:34 AM

hach-que retitled this revision from to Fix custom blueprint attributes to work when no attributes are specified.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T2015: Implement Drydock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 25 2014, 2:34 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2635: Diff 25363.Sep 25 2014, 2:35 AM

joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 9:31 AM

Superseded by D13984.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

util/

DrydockCustomAttributes.php

4 lines

Diff 25363

View Options

src/applications/drydock/util/DrydockCustomAttributes.php

Fix custom blueprint attributes to work when no attributes are specifiedAbandonedPublicActions