Page MenuHomePhabricator
Differential D10517

Fix more race conditions within Drydock
AbandonedPublic
Actions

Authored by hach-que on Sep 18 2014, 4:11 PM.
Tags
None
Referenced Files
F15492510: D10517.id.diff
Sat, Apr 12, 3:18 PM
F15430109: D10517.diff
Mon, Mar 24, 5:43 AM
F15415229: D10517.id.diff
Thu, Mar 20, 4:58 AM
F15415179: D10517.id25273.diff
Thu, Mar 20, 4:38 AM
F15411916: D10517.diff
Wed, Mar 19, 10:19 AM
F15411299: D10517.diff
Wed, Mar 19, 8:59 AM
F15411244: D10517.diff
Wed, Mar 19, 8:56 AM
F15411194: D10517.diff
Wed, Mar 19, 8:54 AM
View All Files
Subscribers
epriestley
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Summary

Ref T2015. This fixes (hopefully) the last few race conditions possible in Drydock.

Test Plan

Tested this on a server that runs 32 builds in parallel (all which lease hosts), and saw all of the resources move to pending and get leases correctly, without any Lease Host steps failing.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2575
Build 2579: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 25273.Sep 18 2014, 4:11 PM
hach-que retitled this revision from to Fix more race conditions within Drydock.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a task: T2015: Implement Drydock.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 18 2014, 4:11 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2575: Diff 25273.Sep 18 2014, 4:12 PM
joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 4:14 AM
epriestley requested changes to this revision.Aug 8 2015, 6:21 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/drydock/worker/DrydockAllocatorWorker.php
85

This is not an upstreamable lock strategy.

This revision now requires changes to proceed.Aug 8 2015, 6:21 PM
hach-que mentioned this in D10304: [drydock/core] Implement resource constraints and correct locking mechanisms with yielding for Drydock.Aug 24 2015, 9:39 AM
hach-que abandoned this revision.Aug 24 2015, 9:41 AM

Merged into D10304.

Revision Contents
Changeset List

Diff 25273

View Options

src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/blueprint/DrydockMinMaxBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/blueprint/DrydockMinMaxExpiryBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/blueprint/DrydockMinMaxTestBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/controller/DrydockLeaseViewController.php

Loading...
View Options

src/applications/drydock/worker/DrydockAllocatorWorker.php

Loading...
Phabricator · Built by Phacility