Page MenuHomePhabricator

Fix issue where Windows machines don't delete lease directory correctly
AbandonedPublic

Authored by hach-que on Sep 18 2014, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 11:11 PM
Unknown Object (File)
Thu, Dec 12, 1:03 AM
Unknown Object (File)
Mon, Dec 9, 12:00 PM
Unknown Object (File)
Thu, Nov 28, 7:42 AM
Unknown Object (File)
Sun, Nov 24, 12:44 PM
Unknown Object (File)
Oct 23 2024, 8:40 PM
Unknown Object (File)
Oct 23 2024, 2:55 AM
Unknown Object (File)
Oct 9 2024, 12:02 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Summary

Ref T2015. Windows machines won't delete directories if there's currently any process running inside them. Thus since "rm .." is run inside the current lease directory, the removal always fails.

This unsets the lease's path before attempting to remove it, so that it will be removed correctly (providing there are no other processes using it still).

Test Plan

Tested by allocating a Windows machine and viewing the Drydock logs.

Diff Detail

Repository
rP Phabricator
Branch
prevent-cwd-change-windows
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2564
Build 2568: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Fix issue where Windows machines don't delete lease directory correctly.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.

Depends on premature changes.

This revision now requires changes to proceed.Aug 8 2015, 6:18 PM