Page MenuHomePhabricator
Differential D10505

Set up support for SES API hosts.
AbandonedPublic
Actions

Authored by epriestley on Sep 17 2014, 3:37 AM.
Tags
None
Referenced Files
F14477346: D10505.diff
Sat, Dec 28, 1:47 PM
Unknown Object (File)
Fri, Dec 13, 11:59 AM
Unknown Object (File)
Fri, Dec 13, 9:16 AM
Unknown Object (File)
Fri, Dec 13, 8:56 AM
Unknown Object (File)
Fri, Dec 13, 7:33 AM
Unknown Object (File)
Wed, Dec 11, 4:53 AM
Unknown Object (File)
Fri, Dec 6, 11:34 PM
Unknown Object (File)
Tue, Dec 3, 10:50 AM
View All Files
Subscribers
arcdigital
• elite.liao
epriestley
ide
john.sandall
Korvin
mikn
Tokens
"Like" token, awarded by arcdigital.

Details

Reviewers
• disciplezero
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5116: Amazon SES mailer does not allow specifying endpoint
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Add amazon-ses.host config value. It is currently defaulted to the same value it would have been if unset, so it should not affect existing users.

Test Plan

Tried with multiple values (default and west coast).

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2554
Build 14024: Run Core Tests
Build 2558: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

• disciplezero updated this revision to Diff 25242.Sep 17 2014, 3:37 AM
• disciplezero retitled this revision from to Set up support for SES API hosts..
• disciplezero updated this object.
• disciplezero edited the test plan for this revision. (Show Details)
• disciplezero added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 17 2014, 3:37 AM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2554: Diff 25242.Sep 17 2014, 3:38 AM
• disciplezero added a task: T5116: Amazon SES mailer does not allow specifying endpoint.Sep 17 2014, 3:39 AM
• elite.liao added a subscriber: • elite.liao.Jan 9 2015, 8:32 AM

写得很好

conf/default.conf.php
337

写得不错

mikn added a subscriber: mikn.Jun 22 2015, 7:50 PM
ide added a subscriber: ide.Sep 1 2015, 5:33 AM

@epriestley are you open to taking this? (Ran into this issue because I got SES set up on the west coast and Amazon makes you contact support if you want to send email from new regions :/)

ide added a comment.Sep 1 2015, 5:35 AM

@disciplezero are you still maintaining this? or should i commandeer it?

conf/default.conf.php
337

Probably should be "amazon-ses.endpoint" for consistency and set to null here.

src/applications/config/option/PhabricatorAWSConfigOptions.php
26

See line 39 for indentation style

john.sandall added a subscriber: john.sandall.Sep 30 2015, 4:11 PM
john.sandall mentioned this in T5116: Amazon SES mailer does not allow specifying endpoint.Oct 2 2015, 4:31 PM
arcdigital awarded a token.Feb 23 2016, 10:58 PM
arcdigital added a subscriber: arcdigital.
eadler mentioned this in D15515: Add `amazon-ses.endpoint` configuration.Mar 25 2016, 7:42 PM
epriestley commandeered this revision.Mar 25 2016, 8:07 PM
epriestley abandoned this revision.
epriestley edited reviewers, added: • disciplezero; removed: epriestley.

Obsoleted by D15515.

Revision Contents
Changeset List

PathSize
conf/
1 line
src/
applications/
config/
option/
8 lines
metamta/
adapter/
3 lines
docs/
user/
configuration/
2 lines

Diff 25242

View Options

conf/default.conf.php

Loading...
View Options

src/applications/config/option/PhabricatorAWSConfigOptions.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailImplementationAmazonSESAdapter.php

Loading...
View Options

src/docs/user/configuration/configuring_outbound_email.diviner

Loading...
Phabricator · Built by Phacility