Page MenuHomePhabricator

Reduce severity of `LINT_BAD_CHARSET` to warning
AbandonedPublic

Authored by joshuaspence on Sep 11 2014, 10:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 11:06 PM
Unknown Object (File)
Fri, Feb 7, 11:06 PM
Unknown Object (File)
Fri, Feb 7, 11:06 PM
Unknown Object (File)
Thu, Jan 23, 4:30 PM
Unknown Object (File)
Thu, Jan 23, 4:30 PM
Unknown Object (File)
Thu, Jan 23, 4:30 PM
Unknown Object (File)
Tue, Jan 21, 7:59 PM
Unknown Object (File)
Tue, Jan 21, 11:55 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I was going to apply this locally, but maybe it makes sense in the upstream?

Test Plan

Modified existing unit test.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2522
Build 2526: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Reduce severity of `LINT_BAD_CHARSET` to warning.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

I think this should remain an error by default -- although work in T4045 and elsewhere will continue making this less severe than it once was, I think it's still worth raising on non-changed lines in the general case. I don't think there's a super strong use case for mixing character sets in source code, and .arclint has reasonable tools for excluding small sets of, e.g., test data now.