Page MenuHomePhabricator
Differential D10459

Fix behaviour of max count on blueprints
AbandonedPublic
Actions

Authored by hach-que on Sep 10 2014, 6:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 6:25 AM
Unknown Object (File)
Mar 24 2024, 6:06 AM
Unknown Object (File)
Mar 18 2024, 7:24 PM
Unknown Object (File)
Jan 19 2024, 4:47 PM
Unknown Object (File)
Jan 15 2024, 5:15 PM
Unknown Object (File)
Jan 12 2024, 10:12 PM
Unknown Object (File)
Jan 7 2024, 4:59 PM
Unknown Object (File)
Jan 3 2024, 7:16 PM
View All Files
Subscribers
epriestley
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Summary

Ref T2015. This fixes the behaviour of blueprints when the user doesn't specify a maximum resource limit. Previously the allocator would treat null as 0 and prevent it from allocating anything. Now it treats null properly as "no maximum".

Test Plan

Tested by specifying no maximum and saw it allocate against the blueprint.

Diff Detail

Repository
rP Phabricator
Branch
max-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2485
Build 2489: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 25153.Sep 10 2014, 6:58 AM
hach-que retitled this revision from to Fix behaviour of max count on blueprints.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a task: T2015: Implement Drydock.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 10 2014, 6:58 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2485: Diff 25153.Sep 10 2014, 6:59 AM
joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 5:40 AM
epriestley requested changes to this revision.Aug 8 2015, 5:50 PM
epriestley edited edge metadata.

Premature until dependencies land.

This revision now requires changes to proceed.Aug 8 2015, 5:50 PM
hach-que abandoned this revision.Aug 24 2015, 3:00 AM

Merged down into D10304 since this is a fix to make D10304 correct anyway.

hach-que mentioned this in D10304: [drydock/core] Implement resource constraints and correct locking mechanisms with yielding for Drydock.Aug 24 2015, 3:04 AM

Revision Contents
Changeset List

Diff 25153

View Options

src/applications/drydock/blueprint/DrydockMinMaxBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/blueprint/DrydockMinMaxExpiryBlueprintImplementation.php

Loading...
Phabricator · Built by Phacility