Differential D10451

Transactions - add infrastructure for "mentions"
ClosedPublic
Actions

Authored by btrahan on Sep 9 2014, 7:59 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T4036: Crosslink object if mentioned somewhere

Commits

Restricted Diffusion Commit
rPc75495e63fa0: Transactions - add infrastructure for "mentions"

Summary

Fixes T4036. Now if you say something on diff X like "This reminds me of Tx and Dy and commitHashFoo and Px." each of those objects gets a little visible transaction that the mention occurred. No feed, email, or notifications.

Test Plan

made a comment like above and verified transactions. also submitted a diff that "Fixes Tx" and Tx did not get the transaction as expected.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 25137.Sep 9 2014, 7:59 PM

btrahan added a task: T4036: Crosslink object if mentioned somewhere.

btrahan retitled this revision from to Transactions - add infrastructure for "mentions".

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptSep 9 2014, 7:59 PM

Harbormaster completed remote builds in B2475: Diff 25137.Sep 9 2014, 8:00 PM

We should pick different constants, 43 and 44 were previously used by TYPE_OBJECT_HAS_COLUMN and TYPE_COLUMN_HAS_OBJECT and need some cleanup (I think I didn't file anything, but @joshuaspence hit a minor related issue earlier). Use 51 + 52 instead?