Page MenuHomePhabricator

Add some additional PHP extensions to the compatibility map
ClosedPublic

Authored by joshuaspence on Sep 7 2014, 6:57 AM.
Tags
None
Referenced Files
F14143626: D10436.id25109.diff
Tue, Dec 3, 5:03 PM
F14142308: D10436.diff
Tue, Dec 3, 12:47 PM
Unknown Object (File)
Mon, Dec 2, 1:08 PM
Unknown Object (File)
Thu, Nov 28, 8:39 PM
Unknown Object (File)
Thu, Nov 28, 1:58 PM
Unknown Object (File)
Wed, Nov 27, 1:48 PM
Unknown Object (File)
Sun, Nov 24, 2:55 PM
Unknown Object (File)
Wed, Nov 20, 9:38 PM
Subscribers

Details

Summary

Because why not?

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Add some additional PHP extensions to the compatibility map.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, btrahan.

Alternatively, we could maybe just include all extensions?

epriestley edited edge metadata.

I don't think there is any reason not to include all extensions.

This revision is now accepted and ready to land.Sep 7 2014, 5:59 PM
joshuaspence edited edge metadata.
  • Include all extensions
joshuaspence edited edge metadata.

Updated to include all extensions... the code seems a bit sketchy, but this is basically how php-compat-info does it.

This revision is now accepted and ready to land.Sep 8 2014, 1:21 PM