phtize some string in ArcanistPhutilXHPASTLinter so that they are translatable.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARCce58b92dff89: Make some strings in `ArcanistPhutilXHPASTLinter` translatable
Not 100% sure that I am doing it right...
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Is it correct to parametrize language independent strings like final or a function name? I figured that PHP is always written in English?
Comment Actions
This is more correct -- we can degrade this to the inlined version (by recognizing that the parameters are constants) but can not do the reverse. It might not matter (depending on whether programmers who happen to be bilingual users do the translations or if we pay professional translators who might not have programming experience) and I'd also accept the less-correct-but-still-probably-correct-enough version with final/abstract in the strings, but this is strictly better.