Page MenuHomePhabricator

Make some strings in `ArcanistPhutilXHPASTLinter` translatable
ClosedPublic

Authored by joshuaspence on Sep 6 2014, 1:41 AM.
Tags
None
Referenced Files
F13986831: D10431.id25127.diff
Mon, Oct 21, 5:51 AM
F13978682: D10431.id25127.diff
Sat, Oct 19, 12:27 AM
F13975252: D10431.id.diff
Fri, Oct 18, 9:22 AM
Unknown Object (File)
Sep 15 2024, 8:05 PM
Unknown Object (File)
Sep 6 2024, 9:58 PM
Unknown Object (File)
Sep 3 2024, 2:25 PM
Unknown Object (File)
Sep 2 2024, 10:45 AM
Unknown Object (File)
Aug 28 2024, 2:17 PM
Subscribers

Details

Summary

phtize some string in ArcanistPhutilXHPASTLinter so that they are translatable.

Test Plan

Not 100% sure that I am doing it right...

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Make some strings in `ArcanistPhutilXHPASTLinter` translatable.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2014, 2:33 PM

Is it correct to parametrize language independent strings like final or a function name? I figured that PHP is always written in English?

This is more correct -- we can degrade this to the inlined version (by recognizing that the parameters are constants) but can not do the reverse. It might not matter (depending on whether programmers who happen to be bilingual users do the translations or if we pay professional translators who might not have programming experience) and I'd also accept the less-correct-but-still-probably-correct-enough version with final/abstract in the strings, but this is strictly better.