Page MenuHomePhabricator
Differential D10430

Add some missing function parameter typehints
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2014, 1:28 AM.
Tags
None
Referenced Files
F14030166: D10430.id25091.diff
Sat, Nov 9, 12:16 AM
F14014145: D10430.id25128.diff
Sat, Nov 2, 11:21 PM
F13982186: D10430.id25128.diff
Sat, Oct 19, 9:43 PM
F13961809: D10430.id25091.diff
Tue, Oct 15, 6:28 AM
Unknown Object (File)
Sep 21 2024, 1:03 AM
Unknown Object (File)
Sep 7 2024, 9:34 PM
Unknown Object (File)
Aug 10 2024, 8:43 AM
Unknown Object (File)
Aug 6 2024, 7:12 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCd4f9526e7626: Add some missing function parameter typehints
Summary

Add some missing function parameter typehints to the ArcanistPhutilXHPASTLinter class.

Test Plan

Eyeball it.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 25091.Sep 6 2014, 1:28 AM
joshuaspence retitled this revision from to Add some missing function parameter typehints.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2014, 1:28 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2448: Diff 25091.Sep 6 2014, 1:29 AM
epriestley accepted this revision.Sep 8 2014, 2:34 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2014, 2:34 PM
joshuaspence closed this revision.Sep 8 2014, 10:27 PM
joshuaspence updated this revision to Diff 25128.

Closed by commit rARCd4f9526e7626 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
6 lines

Diff 25128

View Options

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Loading...
Phabricator · Built by Phacility