Paths

Table of Contentst

Add some missing function parameter typehints
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2014, 1:28 AM.

Tags

None

Referenced Files

	F15415510: D10430.diff
	Thu, Mar 20, 6:20 AM

	F15403707: D10430.id25128.diff
	Tue, Mar 18, 4:35 AM

	F15403706: D10430.id25091.diff
	Tue, Mar 18, 4:35 AM

	F15403658: D10430.id.diff
	Tue, Mar 18, 4:20 AM

	F15403142: D10430.diff
	Tue, Mar 18, 1:59 AM

	F15401894: D10430.id25128.diff
	Mon, Mar 17, 7:41 PM

	F15399547: D10430.diff
	Mon, Mar 17, 5:07 AM

	F15389342: D10430.diff
	Sat, Mar 15, 5:08 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCd4f9526e7626: Add some missing function parameter typehints

Summary

Add some missing function parameter typehints to the ArcanistPhutilXHPASTLinter class.

Test Plan

Eyeball it.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 25091.Sep 6 2014, 1:28 AM

joshuaspence retitled this revision from to Add some missing function parameter typehints.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2014, 1:28 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2448: Diff 25091.Sep 6 2014, 1:29 AM

epriestley accepted this revision.Sep 8 2014, 2:34 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 8 2014, 2:34 PM

Closed by commit rARCd4f9526e7626 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhutilXHPASTLinter.php

6 lines

Diff 25128

View Options

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Add some missing function parameter typehintsClosedPublicActions