Paths

Table of Contentst

Differential D10429

Fix linting for spacing around default parameter assignment in function/method declaration
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2014, 1:22 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC16770ed2104e: Fix linting for spacing around default parameter assignment in function/method…

Summary

Fix linting for spacing around default parameter assignment in function/method declaration so that function foo($x = null) {} is preferred in favor of function foo($x=null) {}.

Test Plan

Modified existing unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 25089.Sep 6 2014, 1:22 AM

joshuaspence retitled this revision from to Fix linting for spacing around default parameter assignment in function/method declaration.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2014, 1:22 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2447: Diff 25089.Sep 6 2014, 1:23 AM

epriestley accepted this revision.Sep 8 2014, 2:34 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 8 2014, 2:34 PM

Closed by commit rARC16770ed2104e (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

30 lines

__tests__/

xhpast/

space-around-operators.lint-test

3 lines

Diff 25157

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/space-around-operators.lint-test

Fix linting for spacing around default parameter assignment in function/method declarationClosedPublicActions