Page MenuHomePhabricator

Phriction - fix edits with subscribers
ClosedPublic

Authored by btrahan on Sep 5 2014, 5:32 PM.
Tags
None
Referenced Files
F14044732: D10426.diff
Tue, Nov 12, 8:10 PM
F13977088: D10426.id25079.diff
Oct 18 2024, 5:01 PM
Unknown Object (File)
Oct 13 2024, 3:00 AM
Unknown Object (File)
Oct 10 2024, 6:35 PM
Unknown Object (File)
Oct 5 2024, 5:28 PM
Unknown Object (File)
Sep 27 2024, 2:36 PM
Unknown Object (File)
Sep 23 2024, 8:34 AM
Unknown Object (File)
Sep 18 2024, 5:11 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPb51ae8f32d9d: Phriction - fix edits with subscribers
Summary

pre-patch, these fatal, since we overwrite $content to be just a string so methods fail later in the code. Instead, write a $content_str to keep $content as the proper data.

Test Plan

editing a document and on save it showed me the view page! (as opposed to fataling and staying on the eidt page)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Phriction - fix edits with subscribers.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2014, 5:37 PM
btrahan updated this revision to Diff 25080.

Closed by commit rPb51ae8f32d9d (authored by @btrahan).