Paths

Table of Contentst

Differential D10423

When adding `{Fnnn}` file references by editing comments, link objects to files
ClosedPublic
Actions

Authored by epriestley on Sep 5 2014, 11:45 AM.

Tags

None

Referenced Files

	F14044592: D10423.id25084.diff
	Tue, Nov 12, 6:22 PM

	F13999994: D10423.diff
	Thu, Oct 24, 6:39 PM

	F13989904: D10423.id.diff
	Mon, Oct 21, 11:46 PM

	F13965143: D10423.id25076.diff
	Oct 16 2024, 12:11 AM

	Unknown Object (File)
	Oct 1 2024, 2:48 AM

	Unknown Object (File)
	Sep 23 2024, 9:15 PM

	Unknown Object (File)
	Sep 23 2024, 3:43 AM

	Unknown Object (File)
	Sep 19 2024, 5:47 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T6037: Files edited into comments don't link to objects

Commits

Restricted Diffusion Commit
rP25f4a23a959f: When adding `{Fnnn}` file references by editing comments, link objects to files

Summary

Fixes T6037. We don't currently write the "this file is attached to such-and-such object" edge on comment edits.

Test Plan

Edited a comment, adding {Fnnn}. Verified file was not attached before the edit, but was afterward.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 25076.Sep 5 2014, 11:45 AM

epriestley retitled this revision from to When adding `{Fnnn}` file references by editing comments, link objects to files.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6037: Files edited into comments don't link to objects.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 5 2014, 11:45 AM

Harbormaster completed remote builds in B2441: Diff 25076.Sep 5 2014, 11:46 AM

inline about the TODO as I think its TODONE and want to clarify for myself.

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
72–73	this ended up getting done generically in the main editor, right?

This revision is now accepted and ready to land.Sep 5 2014, 5:40 PM

Oh, sorry, meant to write an inline about that.

I basically think we're good without having a notification/story about the edit. All the uses I've seen are very normal/boring and I'm never surprised or confused as a user.

Closed by commit rP25f4a23a959f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionCommentEditor.php

21 lines

Diff 25084

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Loading...