Fixes T6037. We don't currently write the "this file is attached to such-and-such object" edge on comment edits.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T6037: Files edited into comments don't link to objects
- Commits
- Restricted Diffusion Commit
rP25f4a23a959f: When adding `{Fnnn}` file references by editing comments, link objects to files
Edited a comment, adding {Fnnn}. Verified file was not attached before the edit, but was afterward.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- editfilelink
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2441 Build 2445: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
inline about the TODO as I think its TODONE and want to clarify for myself.
| src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php | ||
|---|---|---|
| 72–73 | this ended up getting done generically in the main editor, right? | |
Comment Actions
Oh, sorry, meant to write an inline about that.
I basically think we're good without having a notification/story about the edit. All the uses I've seen are very normal/boring and I'm never surprised or confused as a user.