Page MenuHomePhabricator
Differential D10420

Make it easier to ignore setup issues
ClosedPublic
Actions

Authored by epriestley on Sep 5 2014, 1:50 AM.
Tags
None
Referenced Files
F13228038: D10420.id.diff
Mon, May 20, 6:31 AM
Unknown Object (File)
Fri, May 3, 2:12 AM
Unknown Object (File)
Mon, Apr 29, 1:35 PM
Unknown Object (File)
Mon, Apr 29, 3:28 AM
Unknown Object (File)
Apr 24 2024, 9:49 PM
Unknown Object (File)
Apr 21 2024, 3:39 PM
Unknown Object (File)
Apr 19 2024, 5:41 AM
Unknown Object (File)
Apr 17 2024, 2:28 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4331: Allow users to one-click-resolve "extra config" options where the config value is in the database
T5968: "Phabricator Daemons Need Restarting" is too difficult to understand/debug
Commits
Restricted Diffusion Commit
rP3958bf367767: Make it easier to ignore setup issues
Summary

Ref T4331. Ref T5968. Users sometimes have trouble figuring out how to ignore issues. The option is a bit hard to spot, especially if you aren't familiar with interfaces yet.
Make it a button on the issue page itself instead.

Test Plan

Normal issue:

Screen_Shot_2014-09-04_at_6.45.45_PM.png (1×1 px, 152 KB)

Ignored issue:

Screen_Shot_2014-09-04_at_6.45.40_PM.png (1×1 px, 149 KB)

Fatal issue:

Screen_Shot_2014-09-04_at_6.47.52_PM.png (1×1 px, 137 KB)

Diff Detail

Repository
rP Phabricator
Branch
ignoreissue
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2438
Build 2442: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25073.Sep 5 2014, 1:50 AM
epriestley retitled this revision from to Make it easier to ignore setup issues.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added tasks: T5968: "Phabricator Daemons Need Restarting" is too difficult to understand/debug, T4331: Allow users to one-click-resolve "extra config" options where the config value is in the database.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 5 2014, 1:50 AM
epriestley added a comment.Sep 5 2014, 1:50 AM

(The setup-issue.css file gets inlined directly if there's a fatal setup issue, so I can't use color variables.)

Harbormaster completed remote builds in B2438: Diff 25073.Sep 5 2014, 1:51 AM
chad accepted this revision.Sep 5 2014, 4:25 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2014, 4:25 AM
epriestley closed this revision.Sep 5 2014, 7:27 PM
epriestley updated this revision to Diff 25082.

Closed by commit rP3958bf367767 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
config/
check/
2 lines
controller/
2 lines
14 lines
view/
84 lines
webroot/
rsrc/
css/
application/
config/
20 lines

Diff 25073

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/config/check/PhabricatorSetupCheckDaemons.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIgnoreController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

Loading...
View Options

src/applications/config/view/PhabricatorSetupIssueView.php

Loading...
View Options

webroot/rsrc/css/application/config/setup-issue.css

Loading...
Phabricator · Built by Phacility