Page MenuHomePhabricator
Differential D10420

Make it easier to ignore setup issues
ClosedPublic
Actions

Authored by epriestley on Sep 5 2014, 1:50 AM.
Tags
None
Referenced Files
F15464272: D10420.id25082.diff
Wed, Apr 2, 8:04 AM
F15464124: D10420.id.diff
Wed, Apr 2, 6:35 AM
F15464063: D10420.id25073.diff
Wed, Apr 2, 6:04 AM
F15462542: D10420.diff
Tue, Apr 1, 3:50 PM
F15458523: D10420.id.diff
Mon, Mar 31, 4:17 AM
F15415903: D10420.diff
Thu, Mar 20, 8:21 AM
F15414402: D10420.diff
Thu, Mar 20, 12:29 AM
F15395853: D10420.id.diff
Sun, Mar 16, 10:10 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4331: Allow users to one-click-resolve "extra config" options where the config value is in the database
T5968: "Phabricator Daemons Need Restarting" is too difficult to understand/debug
Commits
Restricted Diffusion Commit
rP3958bf367767: Make it easier to ignore setup issues
Summary

Ref T4331. Ref T5968. Users sometimes have trouble figuring out how to ignore issues. The option is a bit hard to spot, especially if you aren't familiar with interfaces yet.
Make it a button on the issue page itself instead.

Test Plan

Normal issue:

Screen_Shot_2014-09-04_at_6.45.45_PM.png (1×1 px, 152 KB)

Ignored issue:

Screen_Shot_2014-09-04_at_6.45.40_PM.png (1×1 px, 149 KB)

Fatal issue:

Screen_Shot_2014-09-04_at_6.47.52_PM.png (1×1 px, 137 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 25073.Sep 5 2014, 1:50 AM
epriestley retitled this revision from to Make it easier to ignore setup issues.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added tasks: T5968: "Phabricator Daemons Need Restarting" is too difficult to understand/debug, T4331: Allow users to one-click-resolve "extra config" options where the config value is in the database.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 5 2014, 1:50 AM
epriestley added a comment.Sep 5 2014, 1:50 AM

(The setup-issue.css file gets inlined directly if there's a fatal setup issue, so I can't use color variables.)

Harbormaster completed remote builds in B2438: Diff 25073.Sep 5 2014, 1:51 AM
chad accepted this revision.Sep 5 2014, 4:25 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2014, 4:25 AM
epriestley closed this revision.Sep 5 2014, 7:27 PM
epriestley updated this revision to Diff 25082.

Closed by commit rP3958bf367767 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
config/
check/
2 lines
controller/
2 lines
14 lines
view/
84 lines
webroot/
rsrc/
css/
application/
config/
20 lines

Diff 25082

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/config/check/PhabricatorSetupCheckDaemons.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIgnoreController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

Loading...
View Options

src/applications/config/view/PhabricatorSetupIssueView.php

Loading...
View Options

webroot/rsrc/css/application/config/setup-issue.css

Loading...
Phabricator · Built by Phacility