Page MenuHomePhabricator

Make it easier to ignore setup issues
ClosedPublic

Authored by epriestley on Sep 5 2014, 1:50 AM.
Tags
None
Referenced Files
F14807519: D10420.id25073.diff
Sun, Jan 26, 9:55 AM
Unknown Object (File)
Fri, Jan 17, 12:33 PM
Unknown Object (File)
Tue, Jan 14, 12:26 PM
Unknown Object (File)
Sat, Jan 4, 11:21 AM
Unknown Object (File)
Sun, Dec 29, 6:11 PM
Unknown Object (File)
Dec 12 2024, 12:54 AM
Unknown Object (File)
Dec 12 2024, 12:54 AM
Unknown Object (File)
Dec 12 2024, 12:54 AM
Subscribers

Details

Summary

Ref T4331. Ref T5968. Users sometimes have trouble figuring out how to ignore issues. The option is a bit hard to spot, especially if you aren't familiar with interfaces yet.
Make it a button on the issue page itself instead.

Test Plan

Normal issue:

Screen_Shot_2014-09-04_at_6.45.45_PM.png (1×1 px, 152 KB)

Ignored issue:

Screen_Shot_2014-09-04_at_6.45.40_PM.png (1×1 px, 149 KB)

Fatal issue:

Screen_Shot_2014-09-04_at_6.47.52_PM.png (1×1 px, 137 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

(The setup-issue.css file gets inlined directly if there's a fatal setup issue, so I can't use color variables.)

chad edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2014, 4:25 AM
epriestley updated this revision to Diff 25082.

Closed by commit rP3958bf367767 (authored by @epriestley).