Highlight numbers in Python import names properly
ClosedPublic
Actions

Authored by sophiebits on Sep 5 2014, 12:15 AM.

Tags

None

Referenced Files

	F13084159: D10418.diff
	Wed, Apr 24, 10:49 PM

	Unknown Object (File)
	Sun, Apr 21, 5:40 PM

	Unknown Object (File)
	Fri, Apr 19, 1:58 AM

	Unknown Object (File)
	Wed, Apr 17, 1:56 PM

	Unknown Object (File)
	Thu, Apr 11, 7:42 AM

	Unknown Object (File)
	Fri, Apr 5, 5:39 PM

	Unknown Object (File)
	Fri, Apr 5, 6:23 AM

	Unknown Object (File)
	Fri, Mar 29, 9:36 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUe29b637875fe: Highlight numbers in Python import names properly

Summary

This was a typo I made when porting the Pygments lexer.

Test Plan

Made a paste with "import webapp2_extras" and saw that the whole "webapp2_extras" was blue (unlike before, when only "webapp" was).

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sophiebits updated this revision to Diff 25070.Sep 5 2014, 12:15 AM

sophiebits retitled this revision from to Highlight numbers in Python import names properly.

sophiebits updated this object.

sophiebits edited the test plan for this revision. (Show Details)

sophiebits added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 5 2014, 12:15 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Sep 5 2014, 12:15 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 5 2014, 12:15 AM

Closed by commit rPHUe29b637875fe (authored by @spicyj, committed by @epriestley).

Harbormaster completed remote builds in B2436: Diff 25070.Sep 5 2014, 12:16 AM

Revision Contents
Changeset List

Path

Size

src/

lexer/

PhutilPythonFragmentLexer.php

4 lines

Diff 25071

View Options

src/lexer/PhutilPythonFragmentLexer.php

Highlight numbers in Python import names properlyClosedPublicActions