Page MenuHomePhabricator

Fix old image macros and memes for logged out users
ClosedPublic

Authored by epriestley on Sep 4 2014, 4:13 PM.
Tags
None
Referenced Files
F15389249: D10411.id25054.diff
Sat, Mar 15, 5:03 AM
F15340973: D10411.diff
Sun, Mar 9, 5:50 PM
F15338565: D10411.diff
Sun, Mar 9, 11:29 AM
Unknown Object (File)
Wed, Feb 26, 12:29 PM
Unknown Object (File)
Sat, Feb 22, 3:23 AM
Unknown Object (File)
Sat, Feb 22, 3:23 AM
Unknown Object (File)
Feb 18 2025, 10:12 PM
Unknown Object (File)
Feb 7 2025, 10:57 PM
Subscribers
Tokens
"Haypence" token, awarded by chad.

Details

Summary

Fixes T6013. Old image macros/memes never had the file edge written.

We also never wrote file edges for audio.

Finally, the meme controller didn't allow public access.

Write edges for images and audio, perform a migration to populate the historic ones, and make the Editor keep them up to date going forward.

Test Plan
  • Updated image, saw new image attach and old image detach.
  • Updated audio, saw new audio attach and old audio detach.
  • Ran migration.
  • Viewed memes as a logged-out user.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix old image macros and memes for logged out users.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 4 2014, 7:29 PM
epriestley updated this revision to Diff 25068.

Closed by commit rP8038af4bd570 (authored by @epriestley).