Page MenuHomePhabricator

[drydock/core] Mark leases as broken when failing to acquiring lease
AbandonedPublic

Authored by epriestley on Sep 4 2014, 7:56 AM.
Tags
None
Referenced Files
F13998775: D10409.diff
Thu, Oct 24, 11:06 AM
F13997094: D10409.id25049.diff
Thu, Oct 24, 2:06 AM
F13993596: D10409.id33739.diff
Wed, Oct 23, 12:00 AM
F13986328: D10409.id25050.diff
Mon, Oct 21, 2:07 AM
F13984383: D10409.id.diff
Sun, Oct 20, 12:59 PM
F13981350: D10409.diff
Sat, Oct 19, 3:57 PM
F13974654: D10409.id33739.diff
Fri, Oct 18, 6:37 AM
F13974360: D10409.id25049.diff
Fri, Oct 18, 5:14 AM

Details

Reviewers
hach-que
Group Reviewers
Blessed Reviewers
Summary

This ensures Drydock leases get marked as Broken when acquiring the lease fails, so that resources don't stay open despite haven't no actual leases against them.

Test Plan

Tested in production

Event Timeline

hach-que retitled this revision from to Mark leases as broken when failing to acquiring lease.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que edited edge metadata.

Also ensure resources are closed if the only active lease was the one that was broken

epriestley edited edge metadata.

Haven't tested this yet

This revision now requires changes to proceed.Aug 8 2015, 5:49 PM
hach-que requested a review of this revision.Aug 24 2015, 2:41 AM
hach-que edited the test plan for this revision. (Show Details)
hach-que edited edge metadata.
hach-que retitled this revision from Mark leases as broken when failing to acquiring lease to [drydock/core] Mark leases as broken when failing to acquiring lease.
hach-que edited edge metadata.

This patch has actually been in production for 6+ months.

epriestley edited reviewers, added: hach-que; removed: epriestley.

This should be handled by D14212 (and companion D14211, for resources) now. They're probably still a bit shaky but basically do the exact same thing this patch does.