Page MenuHomePhabricator

Maniphest - always cc the user, including when creating from template
ClosedPublic

Authored by btrahan on Sep 3 2014, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 3:01 PM
Unknown Object (File)
Tue, Dec 17, 7:47 AM
Unknown Object (File)
Fri, Dec 13, 5:18 AM
Unknown Object (File)
Tue, Dec 10, 7:53 PM
Unknown Object (File)
Sat, Dec 7, 8:35 PM
Unknown Object (File)
Wed, Dec 4, 6:44 AM
Unknown Object (File)
Fri, Nov 29, 12:54 AM
Unknown Object (File)
Thu, Nov 28, 2:39 AM
Subscribers

Details

Summary

Ref T6031. I figure its totally cool to include the user creating the task as a subscriber, even if from the template case, so just do that there too. Code is written such that if the user wasn't already in the subscriber case they end up being the last person in the tokenizer. Theoretically this should make any users who didn't want to be automagically subscribed via the create from template case to remove themselves.

Test Plan

made a template from a task that didn't have me as a subscriber initially and observed i was a subscriber.

Diff Detail

Repository
rP Phabricator
Branch
T6031
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2421
Build 2425: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Maniphest - always cc the user, including when creating from template.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 3 2014, 8:03 PM
btrahan edited edge metadata.
btrahan updated this revision to Diff 25043.

Closed by commit rPb60d0c338a20 (authored by @btrahan).