Page MenuHomePhabricator
Differential D10390

phutil_utf8_shorten => PhutilUTF8StringTruncator
ClosedPublic
Actions

Authored by btrahan on Aug 29 2014, 9:34 PM.
Tags
None
Referenced Files
F15343782: D10390.id25006.diff
Mon, Mar 10, 12:54 AM
Unknown Object (File)
Thu, Feb 27, 7:47 AM
Unknown Object (File)
Thu, Feb 13, 11:36 AM
Unknown Object (File)
Feb 7 2025, 10:52 PM
Unknown Object (File)
Feb 7 2025, 10:52 PM
Unknown Object (File)
Feb 7 2025, 10:52 PM
Unknown Object (File)
Feb 7 2025, 9:24 AM
Unknown Object (File)
Jan 23 2025, 4:05 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Orange Medal" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T3307: Create `phutil_utf8_truncate()` or make `phutil_utf8_shorten()` more sophisticated
Commits
rPHU2de64405cfdf: phutil_utf8_shorten => PhutilUTF8StringTruncator
Summary

Fixes T3307. Clean up the remaining instances and delete the actual function

Test Plan

arc lintypoo

Diff Detail

Repository
rPHU libphutil
Branch
T3307
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2394
Build 2398: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25006.Aug 29 2014, 9:34 PM
btrahan added a task: T3307: Create `phutil_utf8_truncate()` or make `phutil_utf8_shorten()` more sophisticated.
btrahan retitled this revision from to phutil_utf8_shorten => PhutilUTF8StringTruncator.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 29 2014, 9:34 PM
Harbormaster completed remote builds in B2394: Diff 25006.Aug 29 2014, 9:34 PM
epriestley accepted this revision.Aug 29 2014, 9:58 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 29 2014, 9:58 PM
epriestley awarded a token.Aug 29 2014, 9:59 PM
btrahan closed this revision.Aug 29 2014, 10:11 PM
btrahan updated this revision to Diff 25012.

Closed by commit rPHU2de64405cfdf (authored by @btrahan).

Revision Contents
Changeset List

PathSize
src/
1 line
filesystem/
linesofalarge/
__tests__/
4 lines
8 lines
future/
http/
status/
2 lines
markup/
engine/
remarkup/
blockrule/
4 lines
readableserializer/
2 lines
utils/
19 lines

Diff 25006

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/filesystem/linesofalarge/__tests__/LinesOfALargeExecFutureTestCase.php

Loading...
View Options

src/filesystem/linesofalarge/__tests__/LinesOfALargeFileTestCase.php

Loading...
View Options

src/future/http/status/HTTPFutureHTTPResponseStatus.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupTableBlockRule.php

Loading...
View Options

src/readableserializer/PhutilReadableSerializer.php

Loading...
View Options

src/utils/utf8.php

Loading...
Phabricator · Built by Phacility