Page MenuHomePhabricator

Prevent "Wait for Build Commits" from creating billions of logs
ClosedPublic

Authored by hach-que on Aug 29 2014, 4:15 AM.
Tags
None
Referenced Files
F15530809: D10383.id24991.diff
Wed, Apr 23, 7:20 AM
F15502654: D10383.id24999.diff
Mon, Apr 14, 2:54 AM
F15493006: D10383.id.diff
Sat, Apr 12, 8:41 PM
F15492985: D10383.id24999.diff
Sat, Apr 12, 8:26 PM
F15492356: D10383.id24991.diff
Sat, Apr 12, 1:33 PM
F15489881: D10383.diff
Fri, Apr 11, 1:06 PM
F15467369: D10383.id24999.diff
Thu, Apr 3, 2:11 PM
F15444093: D10383.id.diff
Thu, Mar 27, 7:50 AM
Subscribers

Details

Summary

Resolves T5987. This build step was at some point converted to use yielding, which meant that whenever the build step executes it will create a new log. This checks to see if there is an existing log before creating a new one and uses that instead.

Long term we're going to need some way of attaching data to PhabricatorWorkerYieldException that can be read when the build step starts again; this will allow us to move more build steps off while (...) { ... sleep(X); } loops and onto yielding.

Test Plan

Tested locally.

Diff Detail

Repository
rP Phabricator
Branch
wait-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2387
Build 2391: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Prevent "Wait for Build Commits" from creating billions of logs.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 29 2014, 12:40 PM
hach-que updated this revision to Diff 24999.

Closed by commit rPf015cb50fe6a (authored by @hach-que).