Page MenuHomePhabricator

Prevent "Wait for Build Commits" from creating billions of logs
ClosedPublic

Authored by hach-que on Aug 29 2014, 4:15 AM.
Tags
None
Referenced Files
F19525503: D10383.id.diff
Sun, Jan 18, 9:22 AM
F18712151: D10383.id.diff
Sep 29 2025, 5:17 AM
F18643083: D10383.id24991.diff
Sep 19 2025, 1:25 AM
F18551688: D10383.diff
Sep 8 2025, 12:47 PM
F18084147: D10383.id24991.diff
Aug 5 2025, 2:00 PM
F18047961: D10383.diff
Aug 3 2025, 1:15 PM
F18027008: D10383.id.diff
Aug 2 2025, 10:19 PM
F18025745: D10383.id24999.diff
Aug 2 2025, 9:51 PM
Subscribers

Details

Summary

Resolves T5987. This build step was at some point converted to use yielding, which meant that whenever the build step executes it will create a new log. This checks to see if there is an existing log before creating a new one and uses that instead.

Long term we're going to need some way of attaching data to PhabricatorWorkerYieldException that can be read when the build step starts again; this will allow us to move more build steps off while (...) { ... sleep(X); } loops and onto yielding.

Test Plan

Tested locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Prevent "Wait for Build Commits" from creating billions of logs.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 29 2014, 12:40 PM
hach-que updated this revision to Diff 24999.

Closed by commit rPf015cb50fe6a (authored by @hach-que).