Page MenuHomePhabricator

Prevent "Wait for Build Commits" from creating billions of logs
ClosedPublic

Authored by hach-que on Aug 29 2014, 4:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 6:51 PM
Unknown Object (File)
Mon, Feb 24, 9:06 AM
Unknown Object (File)
Fri, Feb 7, 10:51 PM
Unknown Object (File)
Fri, Feb 7, 10:51 PM
Unknown Object (File)
Fri, Feb 7, 10:51 PM
Unknown Object (File)
Fri, Feb 7, 4:31 PM
Unknown Object (File)
Feb 4 2025, 11:20 AM
Unknown Object (File)
Jan 23 2025, 4:03 PM
Subscribers

Details

Summary

Resolves T5987. This build step was at some point converted to use yielding, which meant that whenever the build step executes it will create a new log. This checks to see if there is an existing log before creating a new one and uses that instead.

Long term we're going to need some way of attaching data to PhabricatorWorkerYieldException that can be read when the build step starts again; this will allow us to move more build steps off while (...) { ... sleep(X); } loops and onto yielding.

Test Plan

Tested locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Prevent "Wait for Build Commits" from creating billions of logs.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 29 2014, 12:40 PM
hach-que updated this revision to Diff 24999.

Closed by commit rPf015cb50fe6a (authored by @hach-que).