Page MenuHomePhabricator

Prevent "Wait for Build Commits" from creating billions of logs
ClosedPublic

Authored by hach-que on Aug 29 2014, 4:15 AM.
Tags
None
Referenced Files
F18084147: D10383.id24991.diff
Tue, Aug 5, 2:00 PM
F18047961: D10383.diff
Sun, Aug 3, 1:15 PM
F18027008: D10383.id.diff
Sat, Aug 2, 10:19 PM
F18025745: D10383.id24999.diff
Sat, Aug 2, 9:51 PM
F17969642: D10383.diff
Fri, Aug 1, 2:20 PM
F17770399: D10383.id.diff
Jul 23 2025, 9:34 AM
F17748438: D10383.diff
Jul 21 2025, 11:54 PM
F17727437: D10383.id24999.diff
Jul 19 2025, 3:11 AM
Subscribers

Details

Summary

Resolves T5987. This build step was at some point converted to use yielding, which meant that whenever the build step executes it will create a new log. This checks to see if there is an existing log before creating a new one and uses that instead.

Long term we're going to need some way of attaching data to PhabricatorWorkerYieldException that can be read when the build step starts again; this will allow us to move more build steps off while (...) { ... sleep(X); } loops and onto yielding.

Test Plan

Tested locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Prevent "Wait for Build Commits" from creating billions of logs.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 29 2014, 12:40 PM
hach-que updated this revision to Diff 24999.

Closed by commit rPf015cb50fe6a (authored by @hach-que).