Page MenuHomePhabricator

Adding php -l linter
ClosedPublic

Authored by bluehawk on Aug 27 2014, 9:15 PM.
Tags
None
Referenced Files
F14033539: D10370.id24968.diff
Sat, Nov 9, 6:01 PM
F14027800: D10370.diff
Fri, Nov 8, 9:37 AM
F13993272: D10370.id.diff
Tue, Oct 22, 9:48 PM
F13974130: D10370.id24968.diff
Fri, Oct 18, 4:13 AM
F13962934: D10370.diff
Tue, Oct 15, 1:03 PM
Unknown Object (File)
Oct 11 2024, 2:42 AM
Unknown Object (File)
Oct 11 2024, 2:42 AM
Unknown Object (File)
Oct 11 2024, 2:42 AM

Details

Summary

Adds a linter that checks php files for syntax errors using php -l

Test Plan

Add a section to your .arclint file similar to:

"php": {
  "type": "php",
  "include": "(\\.php$)"
}

Then run arc lint on a php file with a syntax error.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bluehawk retitled this revision from to Adding php -l linter.
bluehawk updated this object.
bluehawk edited the test plan for this revision. (Show Details)
bluehawk added a reviewer: epriestley.
bluehawk added a subscriber: jacobwalker0814.
epriestley edited edge metadata.

Add a unit test too?

src/lint/linter/ArcanistPhpLinter.php
19

Add punctuation.

35

Add punctuation.

39

Return 'php' instead. Don't introduce deprecated configuration. The "bin" option covers this now.

This revision now requires changes to proceed.Aug 27 2014, 9:20 PM
bluehawk edited edge metadata.

Cleanup, more robust, and adding test

This revision is now accepted and ready to land.Aug 28 2014, 12:29 AM
epriestley updated this revision to Diff 24973.

Closed by commit rARC9fc8a2f61b19 (authored by @bluehawk, committed by @epriestley).