Page MenuHomePhabricator

Render remarkup in feed in a mostly reasonable way
ClosedPublic

Authored by epriestley on Aug 26 2014, 8:03 PM.
Tags
None
Referenced Files
F14812755: D10355.id24925.diff
Mon, Jan 27, 8:10 AM
F14810806: D10355.id.diff
Mon, Jan 27, 1:42 AM
F14810805: D10355.id24925.diff
Mon, Jan 27, 1:42 AM
Unknown Object (File)
Sat, Jan 25, 12:59 PM
Unknown Object (File)
Fri, Jan 24, 9:57 AM
Unknown Object (File)
Fri, Jan 24, 9:57 AM
Unknown Object (File)
Fri, Jan 24, 9:57 AM
Unknown Object (File)
Fri, Jan 24, 9:44 AM
Subscribers

Details

Summary

Fixes T4057. This sort of sidesteps the trickiest (but very rare) case of things like embedded slowvotes. We might be able to refine that later.

In the common bad case (macros, large images) it gets reasonable results by using overflow: hidden with max-height.

We use PhabriatorMarkupEngine::summarize() to try to just render the first paragraph.

Test Plan

Screen_Shot_2014-08-26_at_12.57.55_PM.png (630×614 px, 223 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Render remarkup in feed in a mostly reasonable way.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 26 2014, 9:14 PM
epriestley updated this revision to Diff 24937.

Closed by commit rP69b0ac724a7c (authored by @epriestley).