Page MenuHomePhabricator

Prevent artifact key collision when builds are restarted
ClosedPublic

Authored by hach-que on Aug 22 2014, 4:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 2:00 AM
Unknown Object (File)
Fri, Dec 13, 6:38 PM
Unknown Object (File)
Sat, Dec 7, 3:00 AM
Unknown Object (File)
Thu, Dec 5, 11:21 AM
Unknown Object (File)
Sat, Nov 30, 3:49 PM
Unknown Object (File)
Sat, Nov 30, 12:45 AM
Unknown Object (File)
Wed, Nov 20, 3:36 PM
Unknown Object (File)
Nov 16 2024, 10:38 AM
Subscribers

Details

Summary

Ref T1049. Because we no longer destroy artifacts when builds are restarted, we need the build generation number to be part of the artifact key, otherwise we get collisions when restarting builds that contain build steps that emit artifacts.

Test Plan

Ran it with a build plan of "Lease Host" and "Run Command", no longer got an artifact key crash.

Diff Detail

Repository
rP Phabricator
Branch
artifact-build-gen
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2329
Build 2333: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Prevent artifact key collision when builds are restarted.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que edited edge metadata.

Fix up artifact retrieval as well

epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 27 2014, 7:14 PM
hach-que updated this revision to Diff 24966.

Closed by commit rPa26c6147f537 (authored by @hach-que).