Page MenuHomePhabricator

Prevent artifact key collision when builds are restarted
ClosedPublic

Authored by hach-que on Aug 22 2014, 4:21 AM.
Tags
None
Referenced Files
F14055338: D10336.diff
Sat, Nov 16, 10:38 AM
F14042646: D10336.diff
Tue, Nov 12, 5:08 AM
F14029757: D10336.id24882.diff
Fri, Nov 8, 9:14 PM
F14028896: D10336.id24882.diff
Fri, Nov 8, 5:36 PM
F14025833: D10336.diff
Thu, Nov 7, 8:47 PM
F14013869: D10336.id24885.diff
Sat, Nov 2, 5:52 PM
F14007065: D10336.diff
Mon, Oct 28, 11:00 PM
F13993399: D10336.id24882.diff
Tue, Oct 22, 10:35 PM
Subscribers

Details

Summary

Ref T1049. Because we no longer destroy artifacts when builds are restarted, we need the build generation number to be part of the artifact key, otherwise we get collisions when restarting builds that contain build steps that emit artifacts.

Test Plan

Ran it with a build plan of "Lease Host" and "Run Command", no longer got an artifact key crash.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Prevent artifact key collision when builds are restarted.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que edited edge metadata.

Fix up artifact retrieval as well

epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 27 2014, 7:14 PM
hach-que updated this revision to Diff 24966.

Closed by commit rPa26c6147f537 (authored by @hach-que).