Emails - fix duplicate email error
ClosedPublic
Actions

Authored by btrahan on Aug 21 2014, 11:02 PM.

Details

Reviewers

Maniphest Tasks

T5933: When you try to add an email to your account that another user already has, the field incorrectly fills in with "Duplicate"

Commits

Restricted Diffusion Commit
rPd83a9c606b99: Emails - fix duplicate email error

Summary

$email => $e_email. Fixes T5933.

Test Plan

Added an email that was already on another account and got the proper "Duplicate" UI with the duplicate email address still entered

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24877.Aug 21 2014, 11:02 PM

btrahan added a task: T5933: When you try to add an email to your account that another user already has, the field incorrectly fills in with "Duplicate".

btrahan retitled this revision from to Emails - fix duplicate email error.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 21 2014, 11:02 PM

epriestley accepted this revision.Aug 21 2014, 11:02 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 21 2014, 11:02 PM

Harbormaster completed remote builds in B2325: Diff 24877.Aug 21 2014, 11:03 PM

Closed by commit rPd83a9c606b99 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorSettingsPanelEmailAddresses.php

2 lines

Diff 24879

View Options

src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php

Emails - fix duplicate email errorClosedPublicActions