Arcanist - potentially fix some Windows badness
ClosedPublic
Actions

Authored by btrahan on Aug 21 2014, 10:46 PM.

Tags

None

Referenced Files

	F15457614: D10333.diff
	Sun, Mar 30, 5:23 PM

	F15416481: D10333.id24876.diff
	Thu, Mar 20, 11:28 AM

	F15402999: D10333.id24878.diff
	Tue, Mar 18, 1:35 AM

	F15400144: D10333.id.diff
	Mon, Mar 17, 9:57 AM

	F15397848: D10333.diff
	Sun, Mar 16, 10:36 PM

	F15384293: D10333.id24876.diff
	Fri, Mar 14, 7:24 PM

	F15369653: D10333.id24876.diff
	Wed, Mar 12, 7:39 AM

	F15369631: D10333.id24878.diff
	Wed, Mar 12, 7:35 AM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5914: `arc patch` fails to detect that the working copy commit exists?

Commits

rARCec948a276d86: Arcanist - potentially fix some Windows badness

Summary

Fixes T5914, maybs.

Test Plan

will ask users in T5914

Diff Detail

Repository

rARC Arcanist

Branch

T5914

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2324
Build 2328: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24876.Aug 21 2014, 10:46 PM

btrahan added a task: T5914: `arc patch` fails to detect that the working copy commit exists?.

btrahan retitled this revision from to Arcanist - potentially fix some Windows badness.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 21 2014, 10:46 PM

Harbormaster completed remote builds in B2324: Diff 24876.Aug 21 2014, 10:47 PM

Can confirm this fixed the problem for me. Thanks!

Yay!

whatcouldgowrong

This revision is now accepted and ready to land.Aug 21 2014, 10:56 PM

Why / how does this work?

o i c

yaaaaaaaa...

Closed by commit rARCec948a276d86 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

4 lines

Diff 24876

View Options

src/repository/api/ArcanistGitAPI.php

Arcanist - potentially fix some Windows badnessClosedPublicActions