Mark redirects to php.net from symbols as external
ClosedPublic
Actions

Authored by epriestley on Aug 21 2014, 9:39 PM.

Tags

None

Referenced Files

	F14765787: D10332.id24874.diff
	Thu, Jan 23, 3:51 PM

	F14765784: D10332.id24873.diff
	Thu, Jan 23, 3:51 PM

	F14765783: D10332.id.diff
	Thu, Jan 23, 3:51 PM

	F14765781: D10332.diff
	Thu, Jan 23, 3:51 PM

	F14760952: D10332.diff
	Wed, Jan 22, 9:52 PM

	Unknown Object (File)
	Fri, Dec 27, 12:55 AM

	Unknown Object (File)
	Fri, Dec 27, 12:55 AM

	Unknown Object (File)
	Dec 11 2024, 12:46 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5942: Diffusion symbol linking to php.net triggers redirection refusal

Commits

Restricted Diffusion Commit
rP05eb77c0a704: Mark redirects to php.net from symbols as external

Summary

Fixes T5942. These are external but currently unmarked.

Test Plan

Visited link, got redirected.

Diff Detail

Repository

rP Phabricator

Branch

xsymbol

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2323
Build 2327: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24873.Aug 21 2014, 9:39 PM

epriestley retitled this revision from to Mark redirects to php.net from symbols as external.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5942: Diffusion symbol linking to php.net triggers redirection refusal.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 21 2014, 9:39 PM

Harbormaster completed remote builds in B2323: Diff 24873.Aug 21 2014, 9:40 PM

chad accepted this revision.Aug 21 2014, 9:45 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Aug 21 2014, 9:45 PM

Closed by commit rP05eb77c0a704 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionSymbolController.php

2 lines

Diff 24873

View Options

src/applications/diffusion/controller/DiffusionSymbolController.php

Mark redirects to php.net from symbols as externalClosedPublicActions