Paths

Table of Contentst

Make file handles have "/Fxxx" as the URI
ClosedPublic
Actions

Authored by epriestley on Aug 21 2014, 7:16 PM.

Tags

None

Referenced Files

	F14355347: D10330.diff
	Thu, Dec 19, 5:45 PM

	Unknown Object (File)
	Wed, Dec 18, 1:57 AM

	Unknown Object (File)
	Sat, Dec 14, 2:42 PM

	Unknown Object (File)
	Sat, Dec 7, 11:16 AM

	Unknown Object (File)
	Thu, Nov 28, 10:20 PM

	Unknown Object (File)
	Wed, Nov 27, 9:19 PM

	Unknown Object (File)
	Sun, Nov 24, 5:39 PM

	Unknown Object (File)
	Thu, Nov 21, 1:34 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP79c837d505c3: Make file handles have "/Fxxx" as the URI

Summary

Primarily, this fixes searching for F123 in global search.

The info URI is now a better URI than the "best" URI for files, and doesn't have redirect issues.

Test Plan

Searched for F123 in global search.

Diff Detail

Repository

rP Phabricator

Branch

finfouri

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2321
Build 2325: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24870.Aug 21 2014, 7:16 PM

epriestley retitled this revision from to Make file handles have "/Fxxx" as the URI.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 21 2014, 7:16 PM

Harbormaster completed remote builds in B2321: Diff 24870.Aug 21 2014, 7:17 PM

Thanks!

This revision is now accepted and ready to land.Aug 21 2014, 7:18 PM

Closed by commit rP79c837d505c3 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

phid/

PhabricatorFileFilePHIDType.php

2 lines

Diff 24870

View Options

src/applications/files/phid/PhabricatorFileFilePHIDType.php

Make file handles have "/Fxxx" as the URIClosedPublicActions