Differential D10329

Make sure TempFiles are destroyed after a PHP fatal error
ClosedPublic
Actions

Authored by epriestley on Aug 21 2014, 6:39 PM.

Tags

None

Referenced Files

	F13172909: D10329.diff
	Tue, May 7, 5:41 PM

	F13167873: D10329.diff
	Tue, May 7, 7:25 AM

	Unknown Object (File)
	Fri, May 3, 6:13 AM

	Unknown Object (File)
	Fri, Apr 26, 9:23 AM

	Unknown Object (File)
	Thu, Apr 25, 1:04 AM

	Unknown Object (File)
	Fri, Apr 19, 5:40 PM

	Unknown Object (File)
	Thu, Apr 11, 8:45 AM

	Unknown Object (File)
	Wed, Apr 10, 1:34 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL)

Commits

rPHU8695cdb1270b: Make sure TempFiles are destroyed after a PHP fatal error

Summary

Fixes T4284. Object destructors are not called after a fatal, but shutdown functions are.

Test Plan

Created a test script which makes a temp file, then fatals.
Before patch, temp file was left around.
After patch, it is cleaned up.
Explicitly destroyed the tempfile in the script to verify that double-destruction is fine.
Removed fatal to verify that normal behavior works as expected.

Diff Detail

Repository

Branch

tfile

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2319
Build 2323: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24866.Aug 21 2014, 6:39 PM

epriestley retitled this revision from to Make sure TempFiles are destroyed after a PHP fatal error.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL).

Herald added a subscriber: epriestley. · View Herald TranscriptAug 21 2014, 6:39 PM

Harbormaster completed remote builds in B2319: Diff 24866.Aug 21 2014, 6:41 PM

Also null out the path, just in case someone tries to do something silly with a destroyed file.

Harbormaster completed remote builds in B2320: Diff 24867.Aug 21 2014, 6:42 PM

btrahan accepted this revision.Aug 21 2014, 6:49 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 21 2014, 6:49 PM

Closed by commit rPHU8695cdb1270b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

filesystem/

12 lines

Diff 24866

src/filesystem/TempFile.php

Loading...