Fixes T4284. Object destructors are not called after a fatal, but shutdown functions are.
Details
Details
- Created a test script which makes a temp file, then fatals.
- Before patch, temp file was left around.
- After patch, it is cleaned up.
- Explicitly destroyed the tempfile in the script to verify that double-destruction is fine.
- Removed fatal to verify that normal behavior works as expected.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- tfile
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 2319 Build 2323: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
- Also null out the path, just in case someone tries to do something silly with a destroyed file.