Differential D10329

Make sure TempFiles are destroyed after a PHP fatal error
ClosedPublic
Actions

Authored by epriestley on Aug 21 2014, 6:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 11, 6:16 AM

	Unknown Object (File)
	Wed, Dec 11, 5:03 AM

	Unknown Object (File)
	Sat, Dec 7, 1:26 AM

	Unknown Object (File)
	Tue, Dec 3, 8:29 PM

	Unknown Object (File)
	Tue, Dec 3, 8:29 PM

	Unknown Object (File)
	Tue, Dec 3, 8:29 PM

	Unknown Object (File)
	Tue, Dec 3, 8:29 PM

	Unknown Object (File)
	Tue, Dec 3, 8:20 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL)

Commits

rPHU8695cdb1270b: Make sure TempFiles are destroyed after a PHP fatal error

Summary

Fixes T4284. Object destructors are not called after a fatal, but shutdown functions are.

Test Plan

Created a test script which makes a temp file, then fatals.
Before patch, temp file was left around.
After patch, it is cleaned up.
Explicitly destroyed the tempfile in the script to verify that double-destruction is fine.
Removed fatal to verify that normal behavior works as expected.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24866.Aug 21 2014, 6:39 PM

epriestley retitled this revision from to Make sure TempFiles are destroyed after a PHP fatal error.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL).

Herald added a subscriber: epriestley. · View Herald TranscriptAug 21 2014, 6:39 PM

Harbormaster completed remote builds in B2319: Diff 24866.Aug 21 2014, 6:41 PM

Also null out the path, just in case someone tries to do something silly with a destroyed file.

Harbormaster completed remote builds in B2320: Diff 24867.Aug 21 2014, 6:42 PM

btrahan accepted this revision.Aug 21 2014, 6:49 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 21 2014, 6:49 PM

Closed by commit rPHU8695cdb1270b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

filesystem/

14 lines

Diff 24869

src/filesystem/TempFile.php

Loading...