Fix herald "Repository" rule for Revisions and Diffs
ClosedPublic
Actions

Authored by epriestley on Aug 21 2014, 5:52 PM.

Tags

None

Referenced Files

	F13194799: D10326.diff
	Sun, May 12, 9:53 PM

	F13191483: D10326.id24856.diff
	Sat, May 11, 9:38 PM

	F13179279: D10326.diff
	Wed, May 8, 9:05 PM

	Unknown Object (File)
	Mon, May 6, 11:18 AM

	Unknown Object (File)
	Mon, May 6, 11:18 AM

	Unknown Object (File)
	Mon, May 6, 11:16 AM

	Unknown Object (File)
	Mon, May 6, 11:05 AM

	Unknown Object (File)
	Sat, May 4, 6:30 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
nickz
chad

Commits

Restricted Diffusion Commit
rPf50ba4fb070a: Fix herald "Repository" rule for Revisions and Diffs

Summary

This was broken by rP5ac36e8 by a derpy typo.

Test Plan

Ran dry run against a revision with a a repository, saw the field fill in on the transcript.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24856.Aug 21 2014, 5:52 PM

epriestley retitled this revision from to Fix herald "Repository" rule for Revisions and Commits.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: nickz, btrahan, chad.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 21 2014, 5:52 PM

epriestley retitled this revision from Fix herald "Repository" rule for Revisions and Commits to Fix herald "Repository" rule for Revisions and Diffs.Aug 21 2014, 5:52 PM

chad accepted this revision.Aug 21 2014, 5:53 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 21 2014, 5:53 PM

Harbormaster completed remote builds in B2316: Diff 24856.Aug 21 2014, 5:53 PM

Closed by commit rPf50ba4fb070a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldDifferentialAdapter.php

2 lines

Diff 24857

View Options

src/applications/herald/adapter/HeraldDifferentialAdapter.php

Fix herald "Repository" rule for Revisions and DiffsClosedPublicActions