Don't render HTML for "user answered question" transaction if the rendering target is not HTML
ClosedPublic
Actions

Authored by hach-que on Aug 21 2014, 10:14 AM.

Details

Reviewers

epriestley
btrahan

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5817: Formatting for Ponder answers escapes HTML

Commits

Restricted Diffusion Commit
rP0988ddbf2f4c: Don't render HTML for "user answered question" transaction if the rendering…

Summary

Resolves T5817. Continuation of D10231.

This corrects the rendering of the "user answered question" transaction so that it does not incorrectly attempt to render the question handle as HTML in emails if the rendering target is not HTML.

Test Plan

Used bin/mail show-outbound to verify that the email didn't contain escaped HTML when answering a question.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que updated this revision to Diff 24840.Aug 21 2014, 10:14 AM

hach-que retitled this revision from to Don't render HTML for "user answered question" transaction if the rendering target is not HTML.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T5817: Formatting for Ponder answers escapes HTML.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 21 2014, 10:15 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2304: Diff 24840.Aug 21 2014, 10:16 AM

Just use $this->renderHandleLink($object_phid) -- if that does something sketchy, adjust the PHIDType to produce a better handle name (like D10231).

This revision now requires changes to proceed.Aug 21 2014, 11:21 AM