Differential D10231

Fix broken handle rendering in Ponder
ClosedPublic
Actions

Authored by epriestley on Aug 12 2014, 11:33 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T5817: Formatting for Ponder answers escapes HTML

Commits

Restricted Diffusion Commit
rPdedcfd0c9100: Fix broken handle rendering in Ponder

Summary

Ref T5817. This just fixes the markup in emails, the overall behavior still isn't great. I don't want to spend to much time on Ponder until it ends up somewhere nearer the top of the priority queue.

Test Plan

Viewed feed stories and emails, no stray/clearly-broken HTML.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24620.Aug 12 2014, 11:33 AM

epriestley retitled this revision from to Fix broken handle rendering in Ponder.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5817: Formatting for Ponder answers escapes HTML.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 12 2014, 11:33 AM

Harbormaster completed remote builds in B2168: Diff 24620.Aug 12 2014, 11:34 AM

btrahan accepted this revision.Aug 12 2014, 7:08 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 12 2014, 7:08 PM

Closed by commit rPdedcfd0c9100 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

ponder/

phid/

PonderAnswerPHIDType.php

4 lines

storage/

PonderAnswerTransaction.php

10 lines

Diff 24636

View Options

src/applications/ponder/phid/PonderAnswerPHIDType.php