Page MenuHomePhabricator

Don't SIGINT ourselves on bad daemon data
ClosedPublic

Authored by epriestley on Aug 20 2014, 5:34 PM.

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP15385e1fe9b5: Don't SIGINT ourselves on bad daemon data
Summary

If daemon data is mangled, bin/phd restart will SIGINT process 0, which kills it.

uh oh T.T so sad

Test Plan

Used bin/phd start to start daemons; removed PID information from one; saw bin/phd stop shut down cleanly and not kill itself.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24817.Aug 20 2014, 5:34 PM
epriestley retitled this revision from to Don't SIGINT ourselves on bad daemon data.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

I complained about this issue and I approve this commit ;p

btrahan accepted this revision.Aug 20 2014, 8:02 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 20 2014, 8:02 PM
epriestley closed this revision.Aug 20 2014, 8:18 PM
epriestley updated this revision to Diff 24821.

Closed by commit rP15385e1fe9b5 (authored by @epriestley).