Don't SIGINT ourselves on bad daemon data
ClosedPublic
Actions

Authored by epriestley on Aug 20 2014, 5:34 PM.

Details

Reviewers

btrahan

Commits

Summary

If daemon data is mangled, bin/phd restart will SIGINT process 0, which kills it.

uh oh T.T so sad

Test Plan

Used bin/phd start to start daemons; removed PID information from one; saw bin/phd stop shut down cleanly and not kill itself.

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Unit Tests Skipped

epriestley retitled this revision from to Don't SIGINT ourselves on bad daemon data.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

I complained about this issue and I approve this commit ;p

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 20 2014, 8:02 PM

Closed by commit rP15385e1fe9b5 (authored by @epriestley).

			Path	Packages
M			src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24817	a46d1f1		Aug 20 2014, 5:34 PM	★	★
Diff 2	24821	8dd4d5c	Commit rP15385e1fe9b5d21a72c5b75449ebaf00cefdfcb8	Aug 20 2014, 8:18 PM	★	★