Page MenuHomePhabricator
Differential D10306

When destroying an object, destroy its Herald transcripts too
ClosedPublic
Actions

Authored by epriestley on Aug 20 2014, 2:30 AM.
Tags
None
Referenced Files
F13182505: D10306.diff
Thu, May 9, 11:32 PM
Unknown Object (File)
Mon, May 6, 11:18 AM
Unknown Object (File)
Mon, May 6, 11:16 AM
Unknown Object (File)
Mon, May 6, 11:05 AM
Unknown Object (File)
Mon, May 6, 2:11 AM
Unknown Object (File)
Sun, May 5, 8:21 PM
Unknown Object (File)
Wed, May 1, 5:26 AM
Unknown Object (File)
Thu, Apr 25, 12:06 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5915: Allow Herald rules to reject diffs at creation time
Commits
Restricted Diffusion Commit
rPe5acdd85e681: When destroying an object, destroy its Herald transcripts too
Summary

Ref T5915. Make bin/remove destroy a bit more thorough, since Herald transcripts can have field information in them.

Test Plan

Used bin/remove destroy to nuke revisions, saw their transcripts vanish too.

Diff Detail

Repository
rP Phabricator
Branch
heraldscreen3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/system/engine/PhabricatorDestructionEngine.php:54XHP16TODO Comment
Advicesrc/applications/system/engine/PhabricatorDestructionEngine.php:63XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 2287
Build 2291: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24814.Aug 20 2014, 2:30 AM
epriestley retitled this revision from to When destroying an object, destroy its Herald transcripts too.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5915: Allow Herald rules to reject diffs at creation time.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 20 2014, 2:30 AM
Harbormaster completed remote builds in B2287: Diff 24814.Aug 20 2014, 2:31 AM
btrahan accepted this revision.Aug 20 2014, 8:14 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 20 2014, 8:14 PM
epriestley closed this revision.Aug 20 2014, 10:04 PM
epriestley updated this revision to Diff 24826.

Closed by commit rPe5acdd85e681 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
storage/
transcript/
16 lines
system/
engine/
13 lines

Diff 24814

View Options

src/applications/herald/storage/transcript/HeraldTranscript.php

Loading...
View Options

src/applications/system/engine/PhabricatorDestructionEngine.php

Loading...
Phabricator · Built by Phacility