Differential D10287

Remove localhost Drydock allocator
ClosedPublic
Actions

Authored by hach-que on Aug 18 2014, 9:35 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPdf7fb098451c: Remove localhost Drydock allocator

Summary

This has never been enabled by default, and isn't safe. Remove it since people can use preallocated or EC2 hosts.

Test Plan

Removed it; didn't see it appear on the "Create Blueprint" page.

Diff Detail

Repository

rP Phabricator

Branch

remove-localhost-allocator

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2263
Build 2267: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 24775.Aug 18 2014, 9:35 AM

hach-que retitled this revision from to Remove localhost Drydock allocator.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 18 2014, 9:35 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2263: Diff 24775.Aug 18 2014, 9:36 AM

epriestley accepted this revision.Aug 19 2014, 9:49 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 19 2014, 9:49 PM

Closed by commit rPdf7fb098451c (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

drydock/

blueprint/

DrydockLocalHostBlueprintImplementation.php

Diff 24775

View Options

src/__phutil_library_map__.php