Paths

Table of Contentst

Replace ActionHeader minicons with Font icons
ClosedPublic
Actions

Authored by epriestley on Aug 15 2014, 5:47 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5885: Optional limits to Workboard columns (number of cards)

Commits

Restricted Diffusion Commit
rPeaacb4a5113c: Replace ActionHeader minicons with Font icons

Summary

Ref T5885. See D10276.

Currently, ActionHeaders can only have minicons, and we don't use them anywhere and they probably don't make much sense in the product anymore.

Instead, allow them to have font icons. Remove minicons, which have no callsites and probably won't in the future.

Test Plan

Screen_Shot_2014-08-15_at_10.46.11_AM.png (1×1 px, 218 KB)

Grepped for minicons.
Grepped for setHeaderIcon().

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24748.Aug 15 2014, 5:47 PM

epriestley retitled this revision from to Replace ActionHeader minicons with Font icons.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T5885: Optional limits to Workboard columns (number of cards).

Herald added a subscriber: epriestley. · View Herald TranscriptAug 15 2014, 5:47 PM

Also rename the $minicon parameter.

Harbormaster completed remote builds in B2245: Diff 24748.Aug 15 2014, 5:48 PM

Increase whimsy.

Harbormaster completed remote builds in B2246: Diff 24749.Aug 15 2014, 5:48 PM

Harbormaster completed remote builds in B2247: Diff 24750.

This revision is now accepted and ready to land.Aug 15 2014, 5:51 PM

Closed by commit rPeaacb4a5113c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

10 lines

sprite/

manifest/

minicons_dark_1x/

minicons_dark_2x/

minicons_white_1x/

minicons_white_2x/

scripts/

celerity/

generate_sprites.php

1 line

src/

applications/

uiexample/

examples/

PHUIActionHeaderExample.php

38 lines

infrastructure/

celerity/

CeleritySpriteGenerator.php

52 lines

view/

phui/

PHUIActionHeaderView.php

12 lines

PHUIIconView.php

1 line

webroot/

rsrc/

css/

phui/

phui-icon.css

5 lines

sprite-minicons.css

image/

sprite-minicons-X2.png

sprite-minicons.png

Diff 24756

View Options

resources/celerity/map.php

View Options

resources/sprite/manifest/minicons.json

View Options

resources/sprite/minicons_dark_1x/company.png

View Options

resources/sprite/minicons_dark_1x/move.png

View Options

resources/sprite/minicons_dark_1x/public.png

View Options

resources/sprite/minicons_dark_1x/restricted.png

View Options

resources/sprite/minicons_dark_2x/company.png

View Options

resources/sprite/minicons_dark_2x/move.png

View Options

resources/sprite/minicons_dark_2x/public.png

View Options

resources/sprite/minicons_dark_2x/restricted.png

View Options

resources/sprite/minicons_white_1x/company.png

View Options

resources/sprite/minicons_white_1x/move.png

View Options

resources/sprite/minicons_white_1x/public.png

View Options

resources/sprite/minicons_white_1x/restricted.png

View Options

resources/sprite/minicons_white_2x/company.png

View Options

resources/sprite/minicons_white_2x/move.png

View Options

resources/sprite/minicons_white_2x/public.png

View Options

resources/sprite/minicons_white_2x/restricted.png

View Options

scripts/celerity/generate_sprites.php

View Options

src/applications/uiexample/examples/PHUIActionHeaderExample.php

View Options

src/infrastructure/celerity/CeleritySpriteGenerator.php

View Options

src/view/phui/PHUIActionHeaderView.php

View Options

src/view/phui/PHUIIconView.php

View Options

webroot/rsrc/css/phui/phui-icon.css

View Options

webroot/rsrc/css/sprite-minicons.css

View Options

webroot/rsrc/image/sprite-minicons-X2.png

View Options

webroot/rsrc/image/sprite-minicons.png

Replace ActionHeader minicons with Font iconsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24756

resources/celerity/map.php

resources/sprite/manifest/minicons.json

resources/sprite/minicons_dark_1x/company.png

resources/sprite/minicons_dark_1x/move.png

resources/sprite/minicons_dark_1x/public.png

resources/sprite/minicons_dark_1x/restricted.png

resources/sprite/minicons_dark_2x/company.png

resources/sprite/minicons_dark_2x/move.png

resources/sprite/minicons_dark_2x/public.png

resources/sprite/minicons_dark_2x/restricted.png

resources/sprite/minicons_white_1x/company.png

resources/sprite/minicons_white_1x/move.png

resources/sprite/minicons_white_1x/public.png

resources/sprite/minicons_white_1x/restricted.png

resources/sprite/minicons_white_2x/company.png

resources/sprite/minicons_white_2x/move.png

resources/sprite/minicons_white_2x/public.png

resources/sprite/minicons_white_2x/restricted.png

scripts/celerity/generate_sprites.php

src/applications/uiexample/examples/PHUIActionHeaderExample.php

src/infrastructure/celerity/CeleritySpriteGenerator.php

src/view/phui/PHUIActionHeaderView.php

src/view/phui/PHUIIconView.php

webroot/rsrc/css/phui/phui-icon.css

webroot/rsrc/css/sprite-minicons.css

webroot/rsrc/image/sprite-minicons-X2.png

webroot/rsrc/image/sprite-minicons.png

Replace ActionHeader minicons with Font icons
ClosedPublic
Actions

Revision Contents
Changeset List