Page MenuHomePhabricator

Allow columns to have a point limit
ClosedPublic

Authored by epriestley on Aug 15 2014, 5:11 PM.
Tags
None
Referenced Files
F14054844: D10276.diff
Sat, Nov 16, 5:43 AM
F14054328: D10276.id24757.diff
Sat, Nov 16, 12:36 AM
F14053990: D10276.id24757.diff
Fri, Nov 15, 9:14 PM
F14048593: D10276.id24746.diff
Thu, Nov 14, 8:30 AM
F14047812: D10276.id24746.diff
Thu, Nov 14, 5:22 AM
F14046567: D10276.id24752.diff
Wed, Nov 13, 10:02 PM
F14041763: D10276.diff
Mon, Nov 11, 9:22 PM
F14028566: D10276.diff
Fri, Nov 8, 2:10 PM
Subscribers

Details

Summary

Fixes T5885. This implements optional soft point limits for workboard columns, per traditional Kanban.

  • Allow columns to have a point limit set.
  • When a column has a point limit, show it in the header.
  • If a column has too many points in it, show the column and point count in red.

@chad, this could probably use some design tweaks. In particular:

  • I changed the color of "hidden" columns to avoid confusion with "overfull" columns. We might be able to find a better color.
  • UI hints for overfull columns might need adjustment.

(After T4427, we'll let you sum some custom field instead of total number of tasks, which is why this is called "points" rather than "number of tasks".)

Test Plan

Screen_Shot_2014-08-15_at_10.09.53_AM.png (1×1 px, 205 KB)

Note that:

  • "Pre-planning" has a limit, so it shows "4/12".
  • "Planning" has a limit and is overfull, so it shows "5 / 4".
  • Other columns do not have limits.
  • "Post-planning" is a hidden column. This might be too muted now.

Transactions:

Screen_Shot_2014-08-15_at_10.04.24_AM.png (1×1 px, 167 KB)

Error messages / edit screen:

Screen_Shot_2014-08-15_at_10.04.19_AM.png (1×1 px, 135 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Allow columns to have a point limit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a subscriber: chad.
  • Remove special-cased interaction between hidden and limited columns, since we don't need it anymore.

I would probably:

  • Not change the color of the panel.
  • Swap the 'red header' to mean over limit, instead of hidden
  • Probably use darkgrey header and " Boardname" for hidden boards?
btrahan edited edge metadata.

For "hidden" columns, can we put a mild mask over the whole column maybe? Still readable but clearly greyed out compared to the others? This could even fade to normal. (I need coffee maybe)

I like @chad's idea too.

This revision is now accepted and ready to land.Aug 15 2014, 5:28 PM

It looks like I have to refactor a bunch of views to do that, I'll shoot out a separate diff.

epriestley edited edge metadata.
  • Use header icons to show default/hidden.
  • Use header color to show over-the-limit.
  • Make visible hidden columns slightly transparent.

Screen_Shot_2014-08-15_at_11.02.53_AM.png (1×1 px, 208 KB)

epriestley updated this revision to Diff 24757.

Closed by commit rP300910f462a3 (authored by @epriestley).