Page MenuHomePhabricator
Differential D10270

Remarkup - add a regex to blacklist what objects get link
ClosedPublic
Actions

Authored by btrahan on Aug 14 2014, 10:08 PM.
Tags
None
Referenced Files
F14410990: D10270.id.diff
Tue, Dec 24, 8:32 AM
F14410730: D10270.diff
Tue, Dec 24, 8:18 AM
Unknown Object (File)
Sun, Dec 15, 4:24 AM
Unknown Object (File)
Fri, Dec 6, 5:09 AM
Unknown Object (File)
Thu, Dec 5, 3:35 AM
Unknown Object (File)
Wed, Dec 4, 5:13 AM
Unknown Object (File)
Tue, Dec 3, 9:08 PM
Unknown Object (File)
Tue, Dec 3, 9:08 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5453: Blacklist monograms which are also used in normal discussions, like "Q1" (quarter 1)
Commits
Restricted Diffusion Commit
rPff51a1a451f1: Remarkup - add a regex to blacklist what objects get link
Summary

Fixes T5453.

Test Plan

made a remarkup comment that "Q1 is dumb and Q10 is awesome" and only Q10 was linked. changed the new setting to have the value " " and the Q1 also started linking.

Diff Detail

Repository
rP Phabricator
Branch
T5453
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2233
Build 2237: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24730.Aug 14 2014, 10:08 PM
btrahan added a task: T5453: Blacklist monograms which are also used in normal discussions, like "Q1" (quarter 1).
btrahan retitled this revision from to Remarkup - add a regex to blacklist what objects get link.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 14 2014, 10:08 PM
Harbormaster completed remote builds in B2233: Diff 24730.Aug 14 2014, 10:09 PM
epriestley accepted this revision.Aug 14 2014, 10:11 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2014, 10:11 PM
btrahan closed this revision.Aug 14 2014, 10:17 PM
btrahan updated this revision to Diff 24731.

Closed by commit rPff51a1a451f1 (authored by @btrahan).

Revision Contents
Changeset List

PathSize
src/
applications/
config/
option/
12 lines
ponder/
remarkup/
12 lines
docs/
user/
userguide/
10 lines
infrastructure/
markup/
rule/
6 lines

Diff 24730

View Options

src/applications/config/option/PhabricatorCoreConfigOptions.php

Loading...
View Options

src/applications/ponder/remarkup/PonderRemarkupRule.php

Loading...
View Options

src/docs/user/userguide/remarkup.diviner

Loading...
View Options

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php

Loading...
Phabricator · Built by Phacility