Page MenuHomePhabricator
Differential D10257

Use a custom quit message when gracefully shutting down the IRC bot
ClosedPublic
Actions

Authored by epriestley on Aug 13 2014, 8:11 PM.
Tags
None
Referenced Files
F14477429: D10257.diff
Sat, Dec 28, 2:14 PM
Unknown Object (File)
Tue, Dec 24, 1:35 AM
Unknown Object (File)
Tue, Dec 17, 4:45 PM
Unknown Object (File)
Sat, Dec 14, 5:51 PM
Unknown Object (File)
Fri, Dec 13, 4:01 AM
Unknown Object (File)
Fri, Dec 13, 12:35 AM
Unknown Object (File)
Thu, Dec 5, 12:52 AM
Unknown Object (File)
Nov 16 2024, 8:19 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPf1889aa942a5: Use a custom quit message when gracefully shutting down the IRC bot
Summary

Fixes T3173. This doesn't actually fix T3173 but I'm going to redirect that. It does make the bot quit IRC gracefully, with a nicer quit message, which can be customized.

Test Plan

Got a bot to quit IRC with nice messages.

Diff Detail

Repository
rP Phabricator
Branch
ircquit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2213
Build 2217: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24693.Aug 13 2014, 8:11 PM
epriestley retitled this revision from to Use a custom quit message when gracefully shutting down the IRC bot.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 13 2014, 8:11 PM
Harbormaster completed remote builds in B2213: Diff 24693.Aug 13 2014, 8:12 PM
btrahan accepted this revision.Aug 13 2014, 9:55 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 13 2014, 9:55 PM
epriestley closed this revision.Aug 13 2014, 10:33 PM
epriestley updated this revision to Diff 24700.

Closed by commit rPf1889aa942a5 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
infrastructure/
daemon/
bot/
3 lines
adapter/
7 lines
31 lines

Diff 24693

View Options

src/infrastructure/daemon/bot/PhabricatorBot.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorBaseProtocolAdapter.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php

Loading...
Phabricator · Built by Phacility