Probably fix bad method call in Diffusion
ClosedPublic
Actions

Authored by epriestley on Aug 13 2014, 3:26 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4896: Move Audit to ApplicationTransactions
T5869: Crash when viewing lint messages in Diffusion

Commits

Restricted Diffusion Commit
rPa5d24609748c: Probably fix bad method call in Diffusion

Summary

Fixes T5869. Ref T4896. This setID() method no longer exists.

Test Plan

This is a pain to reproduce locally so I'm just winging it. I'm 99% sure this ID is only used to generate an anchor link. This is a hack to start with, and T4896 will eventualy clean it up properly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24685.Aug 13 2014, 3:26 PM

epriestley retitled this revision from to Probably fix bad method call in Diffusion.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T5869: Crash when viewing lint messages in Diffusion, T4896: Move Audit to ApplicationTransactions.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 13 2014, 3:26 PM

Harbormaster completed remote builds in B2208: Diff 24685.Aug 13 2014, 3:27 PM

whatcouldgowrong

This revision is now accepted and ready to land.Aug 13 2014, 4:24 PM

Closed by commit rPa5d24609748c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseFileController.php

1 line

Diff 24686

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Probably fix bad method call in DiffusionClosedPublicActions