Page MenuHomePhabricator
Differential D10254

Probably fix bad method call in Diffusion
ClosedPublic
Actions

Authored by epriestley on Aug 13 2014, 3:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 4:40 PM
Unknown Object (File)
Tue, Dec 24, 4:40 PM
Unknown Object (File)
Tue, Dec 24, 4:40 PM
Unknown Object (File)
Tue, Dec 24, 6:19 AM
Unknown Object (File)
Sun, Dec 22, 11:19 PM
Unknown Object (File)
Fri, Dec 20, 6:38 PM
Unknown Object (File)
Sat, Dec 14, 7:52 PM
Unknown Object (File)
Thu, Dec 12, 10:25 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
T5869: Crash when viewing lint messages in Diffusion
Commits
Restricted Diffusion Commit
rPa5d24609748c: Probably fix bad method call in Diffusion
Summary

Fixes T5869. Ref T4896. This setID() method no longer exists.

Test Plan
This is a pain to reproduce locally so I'm just winging it. I'm 99% sure this ID is only used to generate an anchor link. This is a hack to start with, and T4896 will eventualy clean it up properly.

Diff Detail

Repository
rP Phabricator
Branch
setid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2208
Build 2212: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24685.Aug 13 2014, 3:26 PM
epriestley retitled this revision from to Probably fix bad method call in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5869: Crash when viewing lint messages in Diffusion, T4896: Move Audit to ApplicationTransactions.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 13 2014, 3:26 PM
Harbormaster completed remote builds in B2208: Diff 24685.Aug 13 2014, 3:27 PM
btrahan accepted this revision.Aug 13 2014, 4:24 PM
btrahan edited edge metadata.

whatcouldgowrong

This revision is now accepted and ready to land.Aug 13 2014, 4:24 PM
epriestley closed this revision.Aug 13 2014, 5:06 PM
epriestley updated this revision to Diff 24686.

Closed by commit rPa5d24609748c (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
1 line

Diff 24685

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...
Phabricator · Built by Phacility