Page MenuHomePhabricator

[lint] Add HLint-based Haskell linter
ClosedPublic

Authored by thoughtpolice on Aug 13 2014, 2:17 AM.
Referenced Files
F14024977: D10250.diff
Thu, Nov 7, 1:47 PM
F13977014: D10250.diff
Fri, Oct 18, 4:46 PM
F13971702: D10250.id24665.diff
Thu, Oct 17, 2:52 PM
Unknown Object (File)
Oct 2 2024, 10:10 AM
Unknown Object (File)
Sep 18 2024, 9:25 PM
Unknown Object (File)
Sep 18 2024, 9:23 PM
Unknown Object (File)
Sep 18 2024, 9:20 PM
Unknown Object (File)
Sep 18 2024, 9:18 PM

Details

Summary

This adds a lint engine for hlint, which is the standard and most general Haskell lint tool around these days.

Signed-off-by: Austin Seipp <aseipp@pobox.com>

Test Plan

Install hlint, and run arc unit.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

thoughtpolice retitled this revision from to [lint] Add HLint-based Haskell linter.
thoughtpolice updated this object.
thoughtpolice edited the test plan for this revision. (Show Details)
thoughtpolice edited edge metadata.

Fix unit tests thanks to Evan (too many "~" characters, lololol)

thoughtpolice edited the test plan for this revision. (Show Details)
thoughtpolice added a project: Arcanist.
epriestley edited edge metadata.

One minor thing -- since messages get shipped around, they should just be text.

src/lint/linter/ArcanistHLintLinter.php
74

Unused?

85–86

woah

85–90

These messages get uploaded to the web too, so you probably should avoid console formatting.

This revision now requires changes to proceed.Aug 13 2014, 2:40 AM
src/lint/linter/ArcanistHLintLinter.php
74

Yep.

85–86

I was rather surprised by this behavior too, believe it or not.

85–90

OK, I'll see what else I can cook up.

thoughtpolice edited edge metadata.
  • Remove console formatting from diff
  • Kill unused variable
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 13 2014, 2:48 AM
epriestley updated this revision to Diff 24676.
epriestley added a subscriber: thoughtpolice_.

Closed by commit rARC4c0edd296e33 (authored by @thoughtpolice_, committed by @epriestley).