Page MenuHomePhabricator
Differential D10238

Modularize mail tags
ClosedPublic
Actions

Authored by epriestley on Aug 12 2014, 6:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 12:40 AM
Unknown Object (File)
Wed, Apr 24, 11:48 PM
Unknown Object (File)
Thu, Apr 11, 7:20 PM
Unknown Object (File)
Thu, Apr 11, 7:20 PM
Unknown Object (File)
Thu, Apr 11, 10:54 AM
Unknown Object (File)
Thu, Apr 11, 8:02 AM
Unknown Object (File)
Sun, Apr 7, 2:58 AM
Unknown Object (File)
Fri, Apr 5, 2:43 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5861: Improve the power of email settings
Commits
Restricted Diffusion Commit
rPf6f9d78f3a07: Modularize mail tags
Summary

Ref T5861. Currently, mail tags are hard-coded; move them into applications. Each Editor defines its own tags.

This has zero impact on the UI or behavior.

Test Plan
  • Checked/unchecked some options, saved form.
  • Swapped back to master and saw exactly the same values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24631.Aug 12 2014, 6:14 PM
epriestley retitled this revision from to Modularize mail tags.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T5861: Improve the power of email settings.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 12 2014, 6:14 PM
epriestley added a comment.Aug 12 2014, 6:15 PM

Screen_Shot_2014-08-12_at_11.14.30_AM.png (1×1 px, 267 KB)

epriestley added a comment.Aug 12 2014, 6:16 PM

This has zero impact on the UI or behavior.

Actually, it used to say "Differential" and now it says "Differential Revisions" so I guess that's not 100% true.

(I qualified the object type to accommodate applications which have several editable objects.)

Harbormaster completed remote builds in B2177: Diff 24631.Aug 12 2014, 6:16 PM
btrahan accepted this revision.Aug 12 2014, 7:07 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 12 2014, 7:07 PM
epriestley closed this revision.Aug 12 2014, 7:28 PM
epriestley updated this revision to Diff 24642.

Closed by commit rPf6f9d78f3a07 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
8 lines
auth/
editor/
8 lines
config/
editor/
8 lines
conpherence/
editor/
8 lines
dashboard/
editor/
8 lines
8 lines
differential/
editor/
27 lines
drydock/
editor/
8 lines
files/
editor/
8 lines
harbormaster/
editor/
8 lines
8 lines
8 lines
8 lines
herald/
editor/
8 lines
legalpad/
editor/
8 lines
macro/
editor/
8 lines
maniphest/
editor/
27 lines
nuance/
editor/
8 lines
8 lines
8 lines
8 lines
passphrase/
editor/
8 lines
paste/
editor/
8 lines
people/
editor/
8 lines
phlux/
editor/
8 lines
pholio/
editor/
22 lines
phortune/
editor/
8 lines
8 lines
ponder/
editor/
4 lines
4 lines
4 lines
project/
editor/
8 lines
8 lines
releeph/
editor/
8 lines
8 lines
repository/
editor/
8 lines
settings/
panel/
180 lines
slowvote/
editor/
8 lines
transactions/
editor/
30 lines

Diff 24642

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/auth/editor/PhabricatorAuthProviderConfigEditor.php

Loading...
View Options

src/applications/config/editor/PhabricatorConfigEditor.php

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/drydock/editor/DrydockBlueprintEditor.php

Loading...
View Options

src/applications/files/editor/PhabricatorFileEditor.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildStepEditor.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php

Loading...
View Options

src/applications/herald/editor/HeraldRuleEditor.php

Loading...
View Options

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...
View Options

src/applications/macro/editor/PhabricatorMacroEditor.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/nuance/editor/NuanceItemEditor.php

Loading...
View Options

src/applications/nuance/editor/NuanceQueueEditor.php

Loading...
View Options

src/applications/nuance/editor/NuanceRequestorEditor.php

Loading...
View Options

src/applications/nuance/editor/NuanceSourceEditor.php

Loading...
View Options

src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php

Loading...
View Options

src/applications/paste/editor/PhabricatorPasteEditor.php

Loading...
View Options

src/applications/people/editor/PhabricatorUserProfileEditor.php

Loading...
View Options

src/applications/phlux/editor/PhluxVariableEditor.php

Loading...
View Options

src/applications/pholio/editor/PholioMockEditor.php

Loading...
View Options

src/applications/phortune/editor/PhortuneAccountEditor.php

Loading...
View Options

src/applications/phortune/editor/PhortuneProductEditor.php

Loading...
View Options

src/applications/ponder/editor/PonderAnswerEditor.php

Loading...
View Options

src/applications/ponder/editor/PonderEditor.php

Loading...
View Options

src/applications/ponder/editor/PonderQuestionEditor.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectColumnTransactionEditor.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/releeph/editor/ReleephProductEditor.php

Loading...
View Options

src/applications/releeph/editor/ReleephRequestTransactionalEditor.php

Loading...
View Options

src/applications/repository/editor/PhabricatorRepositoryEditor.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php

Loading...
View Options

src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility